Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register the autoloading earlier so we can load the background jobs #5090

Merged
merged 1 commit into from
May 26, 2017

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented May 24, 2017

Fix nextcloud/news#155

See

\OC_App::registerAutoloading($appId, $basedir);
\OC_App::setupBackgroundJobs($info['background-jobs']);
if(isset($info['settings']) && is_array($info['settings'])) {
\OC::$server->getSettingsManager()->setupSettings($info['settings']);
}
for comparison, maybe we should deduplicate all these calls...

Signed-off-by: Joas Schilling <coding@schilljs.com>
@tobiasKaminsky
Copy link
Member

👍 confirmed

@codecov
Copy link

codecov bot commented May 24, 2017

Codecov Report

Merging #5090 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #5090      +/-   ##
============================================
+ Coverage     54.14%   54.15%   +<.01%     
  Complexity    22283    22283              
============================================
  Files          1379     1379              
  Lines         85337    85336       -1     
  Branches       1322     1322              
============================================
+ Hits          46209    46213       +4     
+ Misses        39128    39123       -5
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/app.php 53.41% <0%> (+0.1%) 219 <0> (ø) ⬇️
apps/comments/lib/EventHandler.php 79.16% <0%> (-8.34%) 7% <0%> (ø)
lib/private/Server.php 93.27% <0%> (-0.15%) 120% <0%> (ø)
core/js/js.js 61.78% <0%> (+0.56%) 0% <0%> (ø) ⬇️
lib/private/Security/CertificateManager.php 91.83% <0%> (+1.02%) 39% <0%> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️

@blizzz blizzz merged commit de953b4 into master May 26, 2017
@blizzz blizzz deleted the try-fixing-missing-background-jobs-on-app-update branch May 26, 2017 08:43
@blizzz
Copy link
Member

blizzz commented May 26, 2017

@nickvergessen do you do the backport?

@rakekniven
Copy link
Member

Updated my NC from v12.0.1 to 12.0.2 and News app did not work.
Had to disable/enable it.

For sure News app has been installed before and was working.

@ccoenen
Copy link

ccoenen commented Oct 3, 2017

exact same behaviour for the news app in the 11.0.5 -> 12.0.3 upgrade.

@nickvergessen
Copy link
Member Author

Are you sure you are not running into #5933 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants