Renamed file logging #523
Merged
Renamed file logging #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the config sample to point to log_type='file' - Renamed the Class for logfile logging to File in namespace 'OC\Log\'. Changed the occurrences of 'OC\Log\Owncloud' to 'OC\Log\File'. - Renamed the Class for log:file command to File in namespace 'OC\Core\Command\Log\File'. Changed registration of the command to use 'OC\Core\Command\Log\File'. - Changed default Syslog tag to Nextcloud - Retained backwards compatibility for configs with 'logtype' => 'owncloud' - Adjusted tests for the new file log. Closes nextcloud#490.
|
@Faldon, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Xenopathic, @bartv2 and @LukasReschke to be potential reviewers |
|
I tested this and it works 👍 Also the code looks good |
| @@ -22,7 +22,7 @@ | |||
| namespace Tests\Core\Command\Log; | |||
|
|
|||
|
|
|||
| use OC\Core\Command\Log\OwnCloud; | |||
| use OC\Core\Command\Log\File; | |||
| use Test\TestCase; | |||
|
|
|||
| class OwnCloudTest extends TestCase { | |||
There was a problem hiding this comment.
Probabaly rename the test as well ;)
|
👍 |
|
Could backport to 10? |
|
cc @karlitschek |
|
backport makes sense 👍 |
Given the current situation I would like to not backport this to stable10 and only keep this in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed file logging from 'owncloud' to 'file'
Closes #490