Don't try to save the setting when its not an admin #5459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
3. to review
MorrisJobke
deleted the
issue-5399-dont-reload-on-subadmin-setting-change
branch
|
@nickvergessen @karlitschek Backport to stable12 at least? And maybe also stable11? |
|
yes please. 👍 |
|
@nickvergessen @MorrisJobke And what about umgmt_show_storage_location ? |
|
I missed that, will fix in a new PR |
This was referenced Jun 20, 2017
|
@nickvergessen @MorrisJobke And backport for stable11? |
|
well we could, or you update to 12? ;) |
|
A release update has to be tested and planed. this takes some time. And in an environment with many group admins, this bug is a problem... |
|
here for you #5499 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5399
@michag86 @MorrisJobke