Don't create activities for email and password change before login #5508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
3. to review
|
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke to be a potential reviewer. |
MorrisJobke
reviewed
Jun 22, 2017
| @@ -78,7 +78,8 @@ public function __construct(IActivityManager $activityManager, | |||
| public function onChangePassword($uid) { | |||
| $user = $this->userManager->get($uid); | |||
|
|
|||
| if (!$user instanceof IUser || $user->getEMailAddress() === null) { | |||
| if (!$user instanceof IUser || $user->getLastLogin() === 0) { | |||
There was a problem hiding this comment.
I would still keep the email address is null, no?
There was a problem hiding this comment.
No, just because the user doesnt have an email, doesnt mean we should not create an activity...
This was basically an accident, because st first there were only emails and i forgot to remove it when adding activities
MorrisJobke
requested review from
LukasReschke,
schiessle,
blizzz and
MariusBluem
blizzz
approved these changes
Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joas Schilling coding@schilljs.com