Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move image-optimization.sh to build dir #5846

Merged
merged 1 commit into from
Jul 24, 2017
Merged

Move image-optimization.sh to build dir #5846

merged 1 commit into from
Jul 24, 2017

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Jul 24, 2017

  • We should not ship this!

Fixes #3186

* We should not ship this!

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@codecov
Copy link

codecov bot commented Jul 24, 2017

Codecov Report

Merging #5846 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #5846      +/-   ##
============================================
- Coverage     53.82%   53.81%   -0.01%     
  Complexity    22732    22732              
============================================
  Files          1403     1403              
  Lines         86644    86644              
  Branches       1327     1327              
============================================
- Hits          46632    46629       -3     
- Misses        40012    40015       +3
Impacted Files Coverage Δ Complexity Δ
core/js/js.js 61.27% <0%> (-0.56%) 0% <0%> (ø)
apps/comments/lib/EventHandler.php 87.5% <0%> (+8.33%) 7% <0%> (ø) ⬇️

@nickvergessen
Copy link
Member

Should we auto execute this on CI?

@rullzer rullzer merged commit 5eee110 into master Jul 24, 2017
@rullzer rullzer deleted the fix_3186 branch July 24, 2017 08:53
@MorrisJobke
Copy link
Member

Should we auto execute this on CI?

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants