Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable12] Top bar buttons in share view are wrong positioned #6112

Merged
merged 3 commits into from
Aug 16, 2017
Merged

[stable12] Top bar buttons in share view are wrong positioned #6112

merged 3 commits into from
Aug 16, 2017

Conversation

MorrisJobke
Copy link
Member

Backport of #5920

@pixelipo @MorrisJobke
Fixes nextcloud/gallery#269
84b0790 
Signed-off-by: Marin Treselj <marin@pixelipo.com>
@pixelipo @MorrisJobke
Change id to class in the main share template
eaa00ea 
Signed-off-by: Marin Treselj <marin@pixelipo.com>
@pixelipo @MorrisJobke
Make sure this still works in other apps.
83616ae 
Signed-off-by: Marin Treselj <marin@pixelipo.com>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Aug 14, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 12.0.3 milestone Aug 14, 2017
This was referenced Aug 14, 2017
Merged
Closed
Merged
@MorrisJobke
Copy link
Member Author

Gallery part: nextcloud/gallery#311

skjnldsv
skjnldsv approved these changes Aug 14, 2017
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 of course

nickvergessen
nickvergessen approved these changes Aug 16, 2017
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better, although the Download arrow and the label are not aligned yet

@nickvergessen nickvergessen merged commit fa8e202 into stable12 Aug 16, 2017
@nickvergessen nickvergessen deleted the backport-5920-12 branch August 16, 2017 09:12
@MorrisJobke
Copy link
Member Author

Looks better, although the Download arrow and the label are not aligned yet

See nextcloud/gallery#311 😉

@pixelipo
Copy link
Contributor

Thanks @MorrisJobke - I didn't have time to create this backport myself...

@MorrisJobke MorrisJobke mentioned this pull request Sep 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@pixelipo pixelipo Awaiting requested review from pixelipo

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 12.0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@MorrisJobke @pixelipo @nickvergessen @skjnldsv