Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkboxes on popover #6976

Merged
merged 2 commits into from
Oct 30, 2017
Merged

Fix checkboxes on popover #6976

merged 2 commits into from
Oct 30, 2017

Conversation

skjnldsv
Copy link
Member

Basic popover

Before After
kazam_screenshot_00000 kazam_screenshot_00001

Sharing popover (not much changes, but removed a lot of unused rules since it's now into all the popovermenus)

Before After
kazam_screenshot_00003 kazam_screenshot_00002

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added the 2. developing Work in progress label Oct 26, 2017
@skjnldsv skjnldsv self-assigned this Oct 26, 2017
@skjnldsv skjnldsv added bug design Design, UI, UX, etc. regression medium 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 26, 2017
@codecov
Copy link

codecov bot commented Oct 27, 2017

Codecov Report

Merging #6976 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #6976      +/-   ##
============================================
+ Coverage     52.82%   52.85%   +0.03%     
- Complexity    22802    22814      +12     
============================================
  Files          1442     1442              
  Lines         88562    88632      +70     
  Branches       1349     1353       +4     
============================================
+ Hits          46783    46848      +65     
- Misses        41779    41784       +5
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
lib/private/Log.php 79.31% <0%> (ø) 50% <0%> (+12%) ⬆️
core/js/js.js 61.94% <0%> (+0.66%) 0% <0%> (ø) ⬇️
lib/private/Security/CertificateManager.php 92.07% <0%> (+0.99%) 39% <0%> (ø) ⬇️
apps/systemtags/js/systemtagsfilelist.js 76.37% <0%> (+3.33%) 0% <0%> (ø) ⬇️

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 👍

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@MorrisJobke MorrisJobke merged commit 42a14ad into master Oct 30, 2017
@MorrisJobke MorrisJobke deleted the fix-checkbox-in-popover branch October 30, 2017 08:45
@MorrisJobke MorrisJobke added this to the Nextcloud 13 milestone Oct 30, 2017
@skjnldsv skjnldsv mentioned this pull request Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. medium regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants