-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix popover layout #7064
Fix popover layout #7064
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Codecov Report
@@ Coverage Diff @@
## master #7064 +/- ##
=========================================
Coverage 50.72% 50.72%
Complexity 24414 24414
=========================================
Files 1579 1579
Lines 93317 93317
Branches 1359 1359
=========================================
Hits 47338 47338
Misses 45979 45979 |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Thanks will fix when home from work! 👌 |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@MorrisJobke All fixed. Please check again :) |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
@nextcloud/designers bump! :) Needed for #7051 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Somehow the various popover layouts broke appart.
My guess is the cleanup we did on various part of the css which may have influenced this.
I also added support for radio since we also support checkboxes after #6976.
Please tests from various locations. Example:
Test template: templatetest.tar.gz
@nextcloud/designers