allow 'Nextcloud' in the user agent string of Android #7462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
MorrisJobke
approved these changes
Dec 12, 2017
|
👍 Nice @schiessle ❤️ |
Codecov Report
@@ Coverage Diff @@
## master #7462 +/- ##
============================================
+ Coverage 51.1% 51.11% +<.01%
Complexity 24900 24900
============================================
Files 1601 1601
Lines 94772 94772
Branches 1367 1367
============================================
+ Hits 48435 48438 +3
+ Misses 46337 46334 -3
|
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
schiessle
force-pushed
the
update-user-agent-regex
branch
from
062d66d
to
caff52d
Compare
This was referenced Dec 12, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is already possible for iOS, this PR also enable it for Android. This way we can effectively block all clients which don't support end-to-end encryption. We should backport it so that the new Android client will also work with older Nextcloud releases.
cc @tobiasKaminsky @AndyScherzinger