Set height for sidebar icons #7769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure they are properly scaled in IE11 Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
added
bug
design
MorrisJobke
approved these changes
Jan 10, 2018
rullzer
approved these changes
Jan 10, 2018
rullzer
added
4. to release
MorrisJobke
approved these changes
Jan 10, 2018
|
backport at #7777 |
|
I think this was more of a fallback. In the future we should definitely avoid using img and go for icons directly :) 👍 nonetheless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure they are properly scaled in IE11
Before:
After:
The scaling issue of the first entry is addressed in nextcloud/activity#230