Add clipboard action to Personal Settings Fed Cloud Id #780
Conversation
|
@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jancborchardt, @schiessle and @LukasReschke to be potential reviewers |
|
works great! Is it by purpose that the cloud ID gets marked if I click on the copy button? Just a small idea, I would consider to add a margin-left to the copy bottom so that it doesn't look to squeezed. Played around in my browser and like the result with 5px. |
|
Yes selecting it basically highlights what you copy. And it makes it easier to directly copy in the case of a failed copy (for some reason). |
|
I'll change the padding |
Before: |
|
beside that it works nice 👍 |
|
Used both comments: Before: After: |
rullzer
force-pushed
the
copy_fed_cloud_id
branch
from
b1fac59
to
6f37a65
Compare
|
looks and works great now 👍 |
MorrisJobke
added
4. to release
| @@ -15,7 +15,8 @@ | |||
|
|
|||
| <p> | |||
| <?php p($l->t('Your Federated Cloud ID:')); ?> | |||
| <strong><?php p($_['cloudId']); ?></strong> | |||
| <strong id="cloudid"><?php p($_['cloudId']); ?></strong> | |||
| <a class="clipboardButton icon icon-clippy" data-clipboard-target="#cloudid"></a> | |||
There was a problem hiding this comment.
The extra .icon class is not needed. ;)
jancborchardt
added
the
papercut
Add clipboard action to Personal Settings Fed Cloud Id
For #735
CC: @MorrisJobke @nickvergessen @icewind1991 @schiessle @jancborchardt @LukasReschke