-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin setting PHP and SMTP casing #784
Conversation
@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @nickvergessen, @LukasReschke and @jancborchardt to be potential reviewers |
Tested and works 👍 |
LGTM |
Backport at #804 |
} | ||
if ($_['mail_smtpmode'] == 'qmail') { | ||
$mail_smtpmode[] = 'qmail'; | ||
$mail_smtpmode[] = ['qmail', 'qmail']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What’s this here … aren’t the two values the same? ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but one is the internal value and the other the shown value ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jancborchardt indeed one is internal and one is what we show. So internally we still use 'php' and 'smtp'. Since I did not want to change all the logic add repair steps and the likes ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks for the info :)
Admin setting PHP and SMTP casing
For #735
CC: @LukasReschke @MorrisJobke @schiessle @nickvergessen @icewind1991