New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Handle SSL certificate verifications for others than Let's Encrypt #8183

Merged
merged 1 commit into from Feb 8, 2018

Conversation

Projects
None yet
3 participants
@robert-scheck
Contributor

robert-scheck commented Feb 5, 2018

Backport of #8182

Do no longer (wrongly) rewrite URLs like

for automated SSL certificate verifications. All (common commercial) certificate authorities (CA) except Let's Encrypt (via ACME) seem to use "pki-validation" rather "acme-challenge" for their domain control validation (DCV).

Signed-off-by: Robert Scheck robert@fedoraproject.org

Handle SSL certificate verifications for others than Let's Encrypt
Do no longer (wrongly) rewrite URLs like

  * http://example.net/.well-known/pki-validation/file.txt (Comodo)
  * http://example.net/.well-known/pki-validation/fileauth.txt (DigiCert, Thawte, GeoTrust)
  * http://example.net/.well-known/pki-validation/gsdv.txt (GlobalSign)
  * http://example.net/.well-known/pki-validation/starfield.htm (Starfield, GoDaddy)
  * http://example.net/.well-known/pki-validation/swisssign-check.txt (SwissSign)

for automated SSL certificate verifications. All (common commercial)
certificate authorities (CA) except Let's Encrypt (via ACME) seem to
use "pki-validation" rather "acme-challenge" for their domain control
validation (DCV).

Signed-off-by: Robert Scheck <robert@fedoraproject.org>

@robert-scheck robert-scheck changed the title from Handle SSL certificate verifications for others than Let's Encrypt to [stable13] Handle SSL certificate verifications for others than Let's Encrypt Feb 5, 2018

@nickvergessen nickvergessen added this to the Nextcloud 13.0.1 milestone Feb 6, 2018

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Feb 6, 2018

Phan failure is fixed in stable13 (#8195)

@rullzer rullzer requested a review from nickvergessen Feb 8, 2018

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Feb 8, 2018

CI failure was fixed in #8195

@MorrisJobke MorrisJobke merged commit e2cb6a3 into nextcloud:stable13 Feb 8, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

13.0.1 RC1 #8748

10 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment