-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update guzzlehttp/guzzle to 6.3.0 #8259
Conversation
CI fails |
Codecov Report
@@ Coverage Diff @@
## master #8259 +/- ##
============================================
- Coverage 51.76% 51.69% -0.07%
- Complexity 25385 25391 +6
============================================
Files 1599 1599
Lines 95102 95119 +17
Branches 1376 1376
============================================
- Hits 49227 49171 -56
- Misses 45875 45948 +73
|
92906ab
to
83ada34
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
ci looks happy, review time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to all still work as far as I can tell.
} | ||
|
||
/** | ||
* @param ResponseInterface $response | ||
*/ | ||
private function extracRequestTokenFromResponse(ResponseInterface $response) { | ||
private function extracRequestTokenFromResponse(\Psr\Http\Message\ResponseInterface $response) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either this is not needed, or the docs is now wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Signed-off-by: Robin Appelman <robin@icewind.nl>
All ready to merge? |
requires:
Needed for updating the openstack sdk
Fixes https://github.com/nextcloud/3rdparty/issues/49