Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable part files for object stores #8715

Merged
merged 2 commits into from Mar 8, 2018
Merged

Conversation

icewind1991
Copy link
Member

Renaming the part file to the target file while preserving fileids can't be done for object stores without issues.

To test

  • upload a new file to s3 object store
  • check the fileid
  • overwrite the file with dav upload
  • check the fileid again

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added this to the Nextcloud 14 milestone Mar 7, 2018
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs more work.

If I checkout this branch we directly create a new version on upload.

Signed-off-by: Robin Appelman <robin@icewind.nl>
@codecov
Copy link

codecov bot commented Mar 8, 2018

Codecov Report

Merging #8715 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #8715      +/-   ##
===========================================
- Coverage     51.87%   51.8%   -0.08%     
- Complexity    25367   25368       +1     
===========================================
  Files          1607    1607              
  Lines         95154   95156       +2     
  Branches       1379    1379              
===========================================
- Hits          49362   49294      -68     
- Misses        45792   45862      +70
Impacted Files Coverage Δ Complexity Δ
...b/private/Files/ObjectStore/ObjectStoreStorage.php 66.66% <0%> (-0.57%) 75 <1> (+1)
lib/private/Files/ObjectStore/Swift.php 0% <0%> (-75%) 8% <0%> (ø)
lib/private/Files/ObjectStore/SwiftFactory.php 0% <0%> (-56.33%) 35% <0%> (ø)
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)

@icewind1991
Copy link
Member Author

@rullzer fixed

(this probably also was an issue when using s2s sharing)

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to do the trick!

@rullzer rullzer merged commit d054699 into master Mar 8, 2018
@rullzer rullzer deleted the objectstore-no-part-files branch March 8, 2018 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants