Dependency Management #8957
Closed
Dependency Management #8957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8957 +/- ##
============================================
- Coverage 51.88% 51.42% -0.47%
Complexity 25270 25270
============================================
Files 1603 1537 -66
Lines 94878 86977 -7901
Branches 1388 0 -1388
============================================
- Hits 49228 44726 -4502
+ Misses 45650 42251 -3399
|
Move bundled PHP libraries from `apps/files_external/3rdparty` to `apps/files_external/vendor` Move bundled JS dependencies from: `core/vendor` to `core/js/vendor` `apps/theming/js/3rdparty` to `apps/theming/js/vendor` `apps/user_ldap/vendor` to `apps/user_ldap/js/vendor` Signed-off-by: Christian Glombek christian.glombek@rwth-aachen.de
MorrisJobke
requested review from
rullzer,
nickvergessen,
icewind1991 and
blizzz
|
Fine by me, I think it's good to have a collection somewhere. |
|
@nickvergessen I think we should try to ensure it, i.e. each time a dependency is updated or changed the files needs to be updated also. Can this be made a general rule? |
|
@nickvergessen @icewind1991 @rullzer What is your opinion on this one? |
|
As I've said before, I don't think a separate file duplicating the info from |
|
See #8555 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8555
Signed-off-by: Christian Glombek christian.glombek@rwth-aachen.de