New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Files external settings polish #902

Merged
merged 8 commits into from Aug 26, 2016

Conversation

Projects
None yet
8 participants
@MariusBluem
Member

MariusBluem commented Aug 17, 2016

@MariusBluem MariusBluem added this to the Nextcloud 10.0 milestone Aug 17, 2016

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 17, 2016

@Mar1u5, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991, @Xenopathic and @jancborchardt to be potential reviewers

mention-bot commented Aug 17, 2016

@Mar1u5, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991, @Xenopathic and @jancborchardt to be potential reviewers

@schiessle

This comment has been minimized.

Show comment
Hide comment
@schiessle

schiessle Aug 17, 2016

Member

backport is incomplete because we lost at least two commits on the master branch, see #787 (comment) @icewind1991 please have a look. Thanks!

Member

schiessle commented Aug 17, 2016

backport is incomplete because we lost at least two commits on the master branch, see #787 (comment) @icewind1991 please have a look. Thanks!

@MariusBluem

This comment has been minimized.

Show comment
Hide comment
@MariusBluem

MariusBluem Aug 17, 2016

Member

As soon as these two commits (#906) are in master, i will add them to the backport 😉

Member

MariusBluem commented Aug 17, 2016

As soon as these two commits (#906) are in master, i will add them to the backport 😉

@MariusBluem

This comment has been minimized.

Show comment
Hide comment
@MariusBluem

MariusBluem Aug 17, 2016

Member
  • Waiting for merge of #906 into master
Member

MariusBluem commented Aug 17, 2016

  • Waiting for merge of #906 into master
@MariusBluem

This comment has been minimized.

Show comment
Hide comment
@MariusBluem

MariusBluem Aug 18, 2016

Member

Backport is now complete 💪 Please review @schiessle @MorrisJobke @icewind1991

Member

MariusBluem commented Aug 18, 2016

Backport is now complete 💪 Please review @schiessle @MorrisJobke @icewind1991

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Aug 19, 2016

Member

Backport is now complete 💪 Please review @schiessle @MorrisJobke @icewind1991

Then also change the label 😉

Member

MorrisJobke commented Aug 19, 2016

Backport is now complete 💪 Please review @schiessle @MorrisJobke @icewind1991

Then also change the label 😉

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Aug 19, 2016

Member

Tested and works 👍

Member

MorrisJobke commented Aug 19, 2016

Tested and works 👍

1 similar comment
@tifredfr

This comment has been minimized.

Show comment
Hide comment
@tifredfr

tifredfr Aug 24, 2016

Tested and works 👍

tifredfr commented Aug 24, 2016

Tested and works 👍

@LukasReschke LukasReschke merged commit 25ed517 into stable10 Aug 26, 2016

3 of 4 checks passed

approvals/lgtm this commit is pending approval
Scrutinizer 4483 Issues, 142 Patches
Details
continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@LukasReschke LukasReschke deleted the stable10-787 branch Aug 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment