Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable13] Fix header nav #9727

Merged
merged 1 commit into from Jun 4, 2018
Merged

[stable13] Fix header nav #9727

merged 1 commit into from Jun 4, 2018

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jun 4, 2018 •
edited

See #9590 馃檲

Fix #9715

@skjnldsv
[stable13] Fix header nav
0159d44 
Signed-off-by: John Molakvo忙 (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews regression labels Jun 4, 2018
@skjnldsv skjnldsv added this to the Nextcloud 13.0.3 milestone Jun 4, 2018
@skjnldsv skjnldsv self-assigned this Jun 4, 2018
juliushaertl
juliushaertl approved these changes Jun 4, 2018
View reviewed changes
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤 Thanks for fixing @skjnldsv

MorrisJobke
MorrisJobke approved these changes Jun 4, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 馃憤

@MorrisJobke MorrisJobke merged commit 778c411 into stable13 Jun 4, 2018
@MorrisJobke MorrisJobke deleted the nav-fix branch June 4, 2018 12:22
This was referenced Jun 4, 2018
Closed
Merged
@rullzer
Copy link
Member

rullzer commented Jun 4, 2018

@skjnldsv can you also fix master?

@MorrisJobke
Copy link
Member

@skjnldsv can you also fix master?

There it was renamed from a class to an ID ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@juliushaertl juliushaertl juliushaertl approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@danxuliu danxuliu Awaiting requested review from danxuliu

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. regression
Projects
None yet
Milestone
Nextcloud 13.0.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skjnldsv @rullzer @MorrisJobke @juliushaertl