Add update info to serverinfo api call

[peschmae]

Add information if nextcloud update is available to the SystemStatistics.
Will show the output of the last update check and not perform a new one.

If no new version is available update. available_version will be null

Fixes #211

[peschmae]

Updated pull requests with fixes from php-cs fixer

[szaimen]

@JuliaKirschenheuter you should be able to merge this already with your review...

[JuliaKirschenheuter]

@blizzz could you please make a second review?

[blizzz]

json_decode invocation

[blizzz]

And another thing, sorry i did not realize it earlier, json_decode() may return null when decoding fails, passing this directly to count will result in an PHP error already. To the decoding earlier (then it's also only needed once) and check for an array and existance of 'version' key, to have this logic robust.

[peschmae]

Refactored logic into handling the lastupdateResult properly, and checking if it's an array or not.
If no new version is available the key available_version will be omitted

[kesselb]

Thank you for your pull request 👍

It would be better if the updatenotification app, which comes with the server, had an endpoint to ask for this information programmatically.

Fine by me to expose that an update is available. If we decide to keep lastupdatedat and available_version this should go into an own method (similar to getAppsInfo) to keep the code simple.

[kesselb]

What do you need lastupdatedat for?

[peschmae]

lastupdatedat is useful to verify that the update check was run recently, and the information isn't totally outdated. I'm open to better ideas how to name it, since it might be unclear what was last updated, the server or the information about updates? (see comment below for indepth response)

[kesselb]

What do you need available_version for?

[peschmae]

Having the available_version exposed, let's us check directly from monitoring if the update is a minor or major upgrade, compared to the installed version. (see comment below for indepth response)

[peschmae]

It would be better if the updatenotification app, which comes with the server, had an endpoint to ask for this information programmatically.

I agree that this might make more sense thematically, but since the available app updates are already exposed by the serverinfo this seems like a reasonable addition.
Currently the serverinfo endpoint is used for most monitoring purposes (eg. https://github.com/xperimental/nextcloud-exporter ), and having the server/core updates exposed to monitoring is very useful to us, as we can have a dashboard showing which instances have updates available.

Having the available_version exposed, let's us check directly from monitoring if the update is a minor or major upgrade, compared to the installed version.

lastupdatedat is useful to verify that the update check was run recently, and the information isn't totally outdated. I'm open to better ideas how to name it, since it might be unclear what was last updated, the server or the information about updates?

[kesselb]

To fix the linter and improve readability.

Index: lib/SystemStatistics.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/lib/SystemStatistics.php b/lib/SystemStatistics.php
--- a/lib/SystemStatistics.php	(revision e0b02a805cb2c1bb3c118d96eb3274ddd6b82a34)
+++ b/lib/SystemStatistics.php	(date 1684832235249)
@@ -77,20 +77,21 @@
 
 	/**
 	 * Get info about server updates and last checked timestamp
-	 * 
+	 *
 	 * @return array information about core updates
 	 */
-	protected function getServerUpdateInfo(): array{
-		$updateInfo = [];
-		$updateInfo['lastupdatedat'] = (int) $this->config->getAppValue('core', 'lastupdatedat');
+	protected function getServerUpdateInfo(): array {
+		$updateInfo = [
+			'lastupdatedat' => (int) $this->config->getAppValue('core', 'lastupdatedat'),
+			'available' => false,
+		];
+
 		$lastUpdateResult = json_decode($this->config->getAppValue('core', 'lastupdateResult'), true);
 		if (is_array($lastUpdateResult)) {
 			$updateInfo['available'] = (count($lastUpdateResult) > 0);
 			if (array_key_exists('version', $lastUpdateResult)) {
 				$updateInfo['available_version'] = $lastUpdateResult['version'];
 			}
-		} else {
-			$updateInfo['available'] = false;
 		}
 
 		return $updateInfo;

To fix the DCO check, please sign off your commits: https://probot.github.io/apps/dco/

[peschmae]

Applied patch, squashed commits, signed-off