Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document icon-url on call rich objects #8389

Closed
nickvergessen opened this issue Nov 22, 2022 · 2 comments · Fixed by #9072
Closed

Document icon-url on call rich objects #8389

nickvergessen opened this issue Nov 22, 2022 · 2 comments · Fixed by #9072
Assignees
@vitormattos
Labels
1. to develop bug feature: api 🛠️ OCS API for conversations, chats and participants high
Milestone
v16.0.3

Comments

@nickvergessen
Copy link
Member

#8333 introduced an optional icon-url for the call objects in rich messages.
This attribute is however not documented in https://github.com/nextcloud/server/blob/d18a293ee50f1a17942391b2031f39fed6ff2eae/lib/public/RichObjectStrings/Definitions.php#L166-L196
@nickvergessen nickvergessen added 1. to develop bug high feature: api 🛠️ OCS API for conversations, chats and participants labels Nov 22, 2022
@nickvergessen nickvergessen added this to the 💟 Next Major (26) milestone Nov 22, 2022
@nickvergessen
Copy link
Member Author

nickvergessen commented Nov 22, 2022 •
edited by vitormattos

Also not all rich objects are currently fed this value:

apps/spreed/lib/Notification/Notifier.php (5 usages found)

  • line 364 'type' => 'call',
  • line 601 'type' => 'call',
  • line 626 'type' => 'call',
  • line 677 'type' => 'call',
  • line 701 'type' => 'call',

vitormattos added a commit to nextcloud/server that referenced this issue Mar 16, 2023
@vitormattos
Document talk icon url definition
8283b31 
nextcloud/spreed#8333 introduced an optional `icon-url`
for the call objects in rich messages.

nextcloud/spreed#8389

Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos vitormattos mentioned this issue Mar 16, 2023
Merged
4 tasks
vitormattos added a commit that referenced this issue Mar 16, 2023
@vitormattos
Document icon-url on call rich objects
1a3aaa2 
#8333 introduced an optional `icon-url`
for the call objects in rich messages.

#8389

Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos vitormattos mentioned this issue Mar 16, 2023
Merged
4 tasks
@vitormattos
Copy link
Contributor

We got commits at this file after the enumerating of rows, now we have different rows and 2 more rows was added to this list.

Also not all rich objects are currently fed this value:

apps/spreed/lib/Notification/Notifier.php (5 usages found)

* [x]  line 364 'type' => 'call',
* [x]  line 601 'type' => 'call',
* [x]  line 626 'type' => 'call',
* [x]  line 677 'type' => 'call',
* [x]  line 701 'type' => 'call',

vitormattos added a commit that referenced this issue Mar 20, 2023
@vitormattos
Document icon-url on call rich objects
e254c80 
#8333 introduced an optional `icon-url`
for the call objects in rich messages.

#8389

Signed-off-by: Vitor Mattos <vitor@php.rio>
vitormattos added a commit that referenced this issue Mar 20, 2023
@vitormattos
Document icon-url on call rich objects
e1972c5 
#8333 introduced an optional `icon-url`
for the call objects in rich messages.

#8389

Signed-off-by: Vitor Mattos <vitor@php.rio>
nickvergessen pushed a commit that referenced this issue Apr 4, 2023
@vitormattos @nickvergessen
Document icon-url on call rich objects
557fab1 
#8333 introduced an optional `icon-url`
for the call objects in rich messages.

#8389

Signed-off-by: Vitor Mattos <vitor@php.rio>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitormattos vitormattos

Labels
1. to develop bug feature: api 🛠️ OCS API for conversations, chats and participants high
Projects
None yet
Milestone
v16.0.3
Development

Successfully merging a pull request may close this issue.

Populate icon-url on call rich objects nextcloud/spreed
2 participants
@nickvergessen @vitormattos