Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate icon-url on call rich objects #9072

Merged
merged 7 commits into from Apr 4, 2023
Merged

Populate icon-url on call rich objects #9072

merged 7 commits into from Apr 4, 2023

Conversation

vitormattos
Copy link
Contributor

@vitormattos vitormattos commented Mar 16, 2023 •
edited by nickvergessen

#8333 introduced an optional icon-url for the call objects in rich messages.

Fix #8389

🏁 Checklist

@vitormattos vitormattos added 3. to review feature: api 🛠️ OCS API for conversations, chats and participants labels Mar 16, 2023
@vitormattos vitormattos added this to the 🖤 Next Major (27) milestone Mar 16, 2023
@vitormattos vitormattos self-assigned this Mar 16, 2023
@vitormattos vitormattos force-pushed the feature/8389/document-icon-url-on-call-rich-objects branch 2 times, most recently from e254c80 to e1972c5 Compare March 20, 2023 13:31
@vitormattos vitormattos force-pushed the feature/8389/document-icon-url-on-call-rich-objects branch from e339bc5 to 75ae7fb Compare March 20, 2023 18:27
@vitormattos vitormattos force-pushed the feature/8389/document-icon-url-on-call-rich-objects branch from 75ae7fb to 1067554 Compare March 20, 2023 18:34
@nickvergessen nickvergessen changed the title Document icon-url on call rich objects Populate icon-url on call rich objects Mar 21, 2023
nickvergessen
nickvergessen requested changes Mar 21, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See both comments

tests/integration/features/chat-2/rich-object-share.feature Outdated Show resolved Hide resolved
vitormattos added a commit that referenced this pull request Mar 21, 2023
@vitormattos
Validate icon-url when test share of rich object
9a38e05 
#9072 (comment)

Signed-off-by: Vitor Mattos <vitor@php.rio>
@nextcloud nextcloud deleted a comment from vitormattos Apr 3, 2023
vitormattos and others added 7 commits April 4, 2023 17:08
@vitormattos @nickvergessen
Document icon-url on call rich objects
557fab1 
#8333 introduced an optional `icon-url`
for the call objects in rich messages.

#8389

Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos @nickvergessen
Fix method to get avatarURL and validate the URL
dfac403 
https://github.com/nextcloud/spreed/pull/9072/files#r1142350857

Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos @nickvergessen
Validate icon-url when test share of rich object
567c7bb 
#9072 (comment)

Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos @nickvergessen
Make the version optional
89f93d4 
We only have the query string "version" when send an avatar after the
first version of avatar

Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos @nickvergessen
COnsider that the icon-url will come every time
de21738 
Signed-off-by: Vitor Mattos <vitor@php.rio>
@nickvergessen
Also default avatar works
a529fea 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(tests): Make sure avatar service is actually called
3c00ae5 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feature/8389/document-icon-url-on-call-rich-objects branch from 10f18ca to 3c00ae5 Compare April 4, 2023 15:15
@nickvergessen nickvergessen merged commit 0ef1c31 into master Apr 4, 2023
25 checks passed
@nickvergessen nickvergessen deleted the feature/8389/document-icon-url-on-call-rich-objects branch April 4, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@vitormattos vitormattos

Labels
3. to review feature: api 🛠️ OCS API for conversations, chats and participants
Projects
💬 Talk team
Archived in project
Milestone
17.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Document icon-url on call rich objects
2 participants
@vitormattos @nickvergessen