Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot delete file/share conversation created by guest #9776

Closed
shalak opened this issue Jun 13, 2023 · 9 comments
Closed

Cannot delete file/share conversation created by guest #9776

shalak opened this issue Jun 13, 2023 · 9 comments

Comments

@shalak
Copy link

shalak commented Jun 13, 2023

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. Create a public share link
  2. Open it in incognito
  3. Join conversation
  4. Go back to your user, try to delete the conversation

Expected behaviour

Owner of the share should be able to delete the conversation

Actual behaviour

Owner can only leave the conversation. Even admin cannot delete it

Talk app

Talk app version: 16.0.4

Custom Signaling server configured: yes

Custom TURN server configured: yes

Custom STUN server configured: yes

Nextcloud configuration:

nextcloud-aio, 26

@shalak shalak changed the title Delete conversation created by guest Cannot delete conversation created by guest Jun 13, 2023
@SystemKeeper
Copy link
Contributor

Thanks for your report!
I am not sure I fully understand that, so if I do the following

  • Be user1
  • Create a public room
  • Let a guest join
  • Try to remove that public room (as user1)

everything works?
Are we talking about a Guest (aka. someone who joined via link) or about a Guest-User (aka. someone who as a Guest account through the guests app)?

In any way you should be able to force delete a room through occ on the command line, check talk:room:delete.

@shalak
Copy link
Author

shalak commented Jun 14, 2023

Huh, I just noticed that if I follow your flow, I'm also unable to delete the conversation as a user1.

I'm assuming that by "Create public room" you mean this:
image

@SystemKeeper
Copy link
Contributor

Ah no, I was on a totally wrong track here. So you create a talk room from a public file share?

@shalak
Copy link
Author

shalak commented Jun 14, 2023

Ah no, I was on a totally wrong track here. So you create a talk room from a public file share?

Yes, I'm creating a public share link

Where can I get the list of possible occ commands for talk? Or just a command to list the rooms?

@SystemKeeper
Copy link
Contributor

Okay, I'll try to reproduce it this way.

You can find a list here: https://nextcloud-talk.readthedocs.io/en/latest/occ/
Also you can disable this on a public share in the settings

@shalak
Copy link
Author

shalak commented Jun 14, 2023

Also you can disable this on a public share in the settings

You mean this one? The Allow conversations on public shares for files?

image

But I want the guests to be able to create, just want to cleanup, if needed.

You can find a list here: https://nextcloud-talk.readthedocs.io/en/latest/occ/

Huh, there's no talk:room:list - how do I identify the room to be deleted?
image

@nickvergessen nickvergessen changed the title Cannot delete conversation created by guest Cannot delete file/share conversation created by guest Jun 20, 2023
@nickvergessen
Copy link
Member

Just for the record, I think as soon as everyone left the conversation, it should be deleted.

@nickvergessen
Copy link
Member

Closing as duplicate of #2236

@nickvergessen nickvergessen closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants