Add icon to go to the file associated to a room #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
If a room is associated to a file now an icon is shown to the right of the room name; when that icon is clicked the Files app is opened in a new tab and focused on the file. The "Go to the file" hint is shown using the tooltip plugin instead of the link title for consistency with other buttons in the UI, and because it is automatically shown when the icon is focused while traversing the UI elements with the tab key. The icon has a clickable area of 44x44px; due to how the properties for h2 elements are defined in the server some margin juggling is needed to vertically align the icon with the room name header. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
In the server, ".icon-file" is set to the "text" icon instead of to the "file" icon. For consistency with the server and between the room list (which uses ".icon-file-white") and the icon to go to the file (which uses ".icon-file") now ".icon-file-white" uses the "text" icon too. Note, however, that the icon for shared files that do not have a preview is still the "file" icon, as in that case it should reflect the file contents and using a text icon for other types of files could be misleading. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
|
/backport to stable15 |
skjnldsv
approved these changes
Dec 13, 2018
|
to be removed in 16 again :( |
nickvergessen
deleted the
add-icon-to-go-to-the-file-associated-to-a-room
branch
|
backport to stable15 in #1398 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the rooms associated to a file are also shown in the regular Talk UI now an icon is shown next to the room name to easily go to the file when clicking on it.
For consistency with the server and between the room list and the new icon the icon in the room list for rooms associated to a file is now the text icon instead of the file icon.
@nextcloud/designers