Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon to go to the file associated to a room #1387

Merged
merged 3 commits into from Dec 13, 2018

Commits on Dec 12, 2018

  1. Remove unused template parameter

    Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    danxuliu committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    16d028e View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2018

  1. Add icon to go to the file associated to a room

    If a room is associated to a file now an icon is shown to the right of
    the room name; when that icon is clicked the Files app is opened in a
    new tab and focused on the file.
    
    The "Go to the file" hint is shown using the tooltip plugin instead of
    the link title for consistency with other buttons in the UI, and because
    it is automatically shown when the icon is focused while traversing the
    UI elements with the tab key.
    
    The icon has a clickable area of 44x44px; due to how the properties for
    h2 elements are defined in the server some margin juggling is needed to
    vertically align the icon with the room name header.
    
    Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    danxuliu committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    79632c1 View commit details
    Browse the repository at this point in the history
  2. Use "text" icon for ".icon-file-white"

    In the server, ".icon-file" is set to the "text" icon instead of to the
    "file" icon. For consistency with the server and between the room list
    (which uses ".icon-file-white") and the icon to go to the file (which
    uses ".icon-file") now ".icon-file-white" uses the "text" icon too.
    
    Note, however, that the icon for shared files that do not have a preview
    is still the "file" icon, as in that case it should reflect the file
    contents and using a text icon for other types of files could be
    misleading.
    
    Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    danxuliu committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    27893b3 View commit details
    Browse the repository at this point in the history