Add reason for removing participant from room #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancycode
requested changes
Dec 19, 2018
nickvergessen
force-pushed
the
remove_participant_reason
branch
2 times, most recently
from
6dcd898
to
dde3785
Compare
nickvergessen
approved these changes
Jan 14, 2019
nickvergessen
added
3. to review
enhancement
feature: api 🛠️
nickvergessen
force-pushed
the
remove_participant_reason
branch
from
dde3785
to
eab3591
Compare
|
Rebased to fix conflicts and and also added it to the event of removeUser |
…ine if the user was removed by moderator. Signed-off-by: Peter Edens <petere@conceiva.com>
nickvergessen
force-pushed
the
remove_participant_reason
branch
from
eab3591
to
4ca16cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removeParticipantBySession function is called when a user is removed by a moderator and also when the user leaves by themselves, for a hook that performs an action when a user is removed there needs to be a flag to indicate that the moderator removed the user. I have added a $reason parameter which can be 'remove' for a moderator and 'leave' if the user just left.