[stable15] Fix peer creation when wrong user list was sent to the other peer #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
In some circumstances (for example, if the signaling server provides an incorrect list of users) the peer that created the offer can disconnect from the peer that received the offer without causing the peer that received the offer to remove the peer that created the offer. In that situation, if the peer that created the offer then tried to connect again with the other peer the other peer created a new "Peer" object that was used instead of the old one. However, as the old one was not removed, its video element (which was no longer updated) was kept visible, hiding the video element linked to the new "Peer" object and making it look frozen. It is not possible to ensure that the peer that received the offer will always remove the peer that created the offer if the peer that created the offer disconnects from the peer that received the offer, so this is handled instead by removing the stale "Peer" objects when new offers are received. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
In some circumstances (for example, if the signaling server provides an incorrect list of users) the peer that received the offer can disconnect from the peer that created the offer without causing the peer that created the offer to disconnect from the peer that received the offer too. A peer only tried to connect with another peer if its session ID was larger than the session ID of the other peer; otherwise it just waited for the other peer to start the connection instead. This is done that way to prevent overloading a peer joining a room. However, in the scenario above, the peer that received the offer just waited for the peer that created the offer to start the connection again. As the peer that created the offer was not aware of the disconnection it did not try to connect again, and thus they never reconnected. It is not possible to ensure that the peer that created the offer will always disconnect from the peer that received the offer if the peer that received the offer disconnects from the peer that created the offer, so this is handled instead by making that peers with smaller session IDs also start a connection if the peer with the larger session ID did not in a reasonable time. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
backportbot-nextcloud
bot
requested review from
danxuliu,
Ivansss and
nickvergessen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #1533