[stable19] Show sidebar when Viewer is opened #3679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
The Viewer expects that, if the app has a sidebar, an "OCA.Files.Sidebar" object exists. This object should contain a "state.file" property with the name of the file currently shown (or an empty string if the sidebar is closed), and "open" and "close" functions to be called by the Viewer when opening and closing the sidebar is triggered by the Viewer. The sidebar adjusts its width to the width of the sidebar once the opening ends. The sidebar comes from nextcloud/vue, and its opening is animated with a transition, so "OCA.Files.Sidebar.open" needs to wait until the transition ends to be resolved. Besides the "OCA.Files.Sidebar" object the Viewer also expects that the sidebar element in the DOM has an "app-sidebar" id. In nextcloud/vue >= 2.0.0 the id of the sidebar was changed to "app-sidebar-vue", so it needs to be overridden to be found by the Viewer. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
backportbot-nextcloud
bot
requested review from
danxuliu,
nickvergessen and
skjnldsv
nickvergessen
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #3665