Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less participant queries #4189

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Less participant queries #4189

merged 2 commits into from
Sep 22, 2020

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Sep 21, 2020 •
edited
Loading

Should reduce the number of those queries a lot:

SELECT * FROM `oc_talk_participants` WHERE (`user_id` = 'xxx') AND (`room_id` = '1234')

and will instead left join the participant on the initial query. That in itself is not a big help. But in case we ask for the same participant more than once (hint, happens every time), we save N-1 queries

it was 1122 queries of the 7873 in our query log

@nickvergessen nickvergessen added this to the 💚 Next Major (21) milestone Sep 21, 2020
@nickvergessen nickvergessen force-pushed the feature/noid/less-participant-queries branch from 3fa9d5b to 68660a0 Compare September 21, 2020 15:38
rullzer
rullzer approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

@nickvergessen nickvergessen force-pushed the feature/noid/less-participant-queries branch 2 times, most recently from b55e864 to 36548c4 Compare September 22, 2020 09:10
@nickvergessen
Allow to preload a user when getting the room by token
9a599f1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feature/noid/less-participant-queries branch from e163d2d to 9a599f1 Compare September 22, 2020 11:09
danxuliu
danxuliu requested changes Sep 22, 2020
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests need to be adjusted.

@nickvergessen
Fix unit tests
c0227ea 
Signed-off-by: Joas Schilling <coding@schilljs.com>
danxuliu
danxuliu approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@nickvergessen nickvergessen merged commit 5bd5779 into master Sep 22, 2020
@nickvergessen nickvergessen deleted the feature/noid/less-participant-queries branch September 22, 2020 19:11
@nickvergessen
Copy link
Member Author

/backport to stable20

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@danxuliu danxuliu danxuliu approved these changes

Assignees
No one assigned
Labels
3. to review feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings technical debt
Projects
None yet
Milestone
v11.0.0-alpha.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @rullzer @danxuliu