Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a more descriptive displayId #6437

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Nov 2, 2021

Use a more descriptive displayId for the profile action, "Reach me via Talk" instead of just "Talk", so that it's clearer when users are configuring their profile settings, as suggested by @nimishavijay

i.e.
image

@nickvergessen
Copy link
Member

IIRC we avoid using me/you as much as possible in the UI.

@nickvergessen
Copy link
Member

Also it's the reverse of the Avatar menu action Talk to X, so the wording should somehow align from my POV.

@nickvergessen
Copy link
Member

Ah wait, it's only the label of the settings option?

@Pytal
Copy link
Member Author

Pytal commented Nov 3, 2021

IIRC we avoid using me/you as much as possible in the UI.

Also it's the reverse of the Avatar menu action Talk to X, so the wording should somehow align from my POV.

Yep, @nextcloud/designers feel free to adjust :)

Ah wait, it's only the label of the settings option?

Currently yes, just used when the user configures visibility

@Pytal Pytal marked this pull request as ready for review November 4, 2021 22:49
@Pytal Pytal force-pushed the enh/profile-descriptive-displayid branch from e1452b5 to c232ba5 Compare November 4, 2021 22:51
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the enh/profile-descriptive-displayid branch from c232ba5 to addb531 Compare November 4, 2021 22:53
@nickvergessen
Copy link
Member

Btw being able to set it to "Everyone" although it's maximum is "logged in users" might lead to some confusion in the future. But fine for now I guess

@nickvergessen nickvergessen merged commit 6398366 into master Nov 5, 2021
@nickvergessen nickvergessen deleted the enh/profile-descriptive-displayid branch November 5, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants