Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to delete shared files and objects #7047

Merged
merged 3 commits into from
Mar 24, 2022
Merged

Allow to delete shared files and objects #7047

merged 3 commits into from
Mar 24, 2022

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Mar 24, 2022 •
edited
Loading

  • Implement on API
  • Add/adjust unit test
  • Add/adjust integration test
  • Implement in web UI

Remarks:

  • Moderators and owner of the share will unshare the share completely, others can only remove the message
  • Files currently always remain available for the owner as per long discussions in the past, because we can not know if the file is used in any other way in parallel.

@nickvergessen nickvergessen added 2. developing bug feature: api 🛠️ OCS API for conversations, chats and participants feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings labels Mar 24, 2022
@nickvergessen nickvergessen added this to the 💛 Next Major (24) milestone Mar 24, 2022
@nickvergessen nickvergessen force-pushed the bugfix/6990/allow-to-delete-shared-files-and-objects branch from a1a5939 to bfe3045 Compare March 24, 2022 08:36
@nickvergessen nickvergessen marked this pull request as ready for review March 24, 2022 09:03
@nickvergessen
Copy link
Member Author

I guess it needs another capability for the mobile clients to do the same adjustment as the web did? cc @Ivansss

@Ivansss
Copy link
Member

Ivansss commented Mar 24, 2022

Yep, it will be nice to have a capability for this :)

@nickvergessen nickvergessen force-pushed the bugfix/6990/allow-to-delete-shared-files-and-objects branch from 6b28ca8 to b2d3cc4 Compare March 24, 2022 15:26
@nickvergessen nickvergessen force-pushed the bugfix/6990/allow-to-delete-shared-files-and-objects branch from b2d3cc4 to 3a46675 Compare March 24, 2022 16:08
@nickvergessen
Copy link
Member Author

Rebased to solve conflict as I fixed something that was fixed in #7024

@nickvergessen
Allow to delete files and object shares on the API
6254397 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Allow to delete shared files and objects from the web
7c325c6 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Add new capability
4a2f851 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/6990/allow-to-delete-shared-files-and-objects branch from 3a46675 to 4a2f851 Compare March 24, 2022 20:50
@nickvergessen nickvergessen merged commit 1452443 into master Mar 24, 2022
@nickvergessen nickvergessen deleted the bugfix/6990/allow-to-delete-shared-files-and-objects branch March 24, 2022 22:29
@Ivansss Ivansss mentioned this pull request Mar 29, 2022
Merged
@Ivansss Ivansss mentioned this pull request Mar 29, 2022
Closed
This was referenced Apr 6, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@vitormattos vitormattos Awaiting requested review from vitormattos

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees
No one assigned
Labels
4. to release bug feature: api 🛠️ OCS API for conversations, chats and participants feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings
Projects
None yet
Milestone
v14.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @Ivansss @marcoambrosini