⏺ Call recording ⚒ Server API - Start/stop recording - Part 2 #8446

vitormattos · 2022-12-08T03:16:38Z

parent: #8445

🚧 TODO

Specify room API attribute for "the call is being recorded"
Specify API endpoint to start a recording
Specify API endpoint to stop a recording

🏁 Checklist

⛑️ Tests (unit and/or integration) are included
📘 API documentation in docs/ has been updated or is not required
📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required
🔖 Capability is added or not needed

Signed-off-by: Vitor Mattos <vitor@php.rio>

appinfo/routes/routesCallController.php

docs/call.md

lib/Chat/Parser/SystemMessage.php

tests/integration/features/bootstrap/FeatureContext.php

lib/Controller/CallController.php

lib/Service/RoomService.php

Signed-off-by: Vitor Mattos <vitor@php.rio>

https://github.com/nextcloud/spreed/pull/8446/files#r1044871679 Signed-off-by: Vitor Mattos <vitor@php.rio>

Signed-off-by: Vitor Mattos <vitor@php.rio>

nickvergessen

Getting there

docs/constants.md

docs/index.md

docs/recording.md

lib/Chat/Parser/SystemMessage.php

lib/Service/RoomService.php

lib/Signaling/Listener.php

Signed-off-by: Vitor Mattos <vitor@php.rio>

#8446 (comment) Signed-off-by: Vitor Mattos <vitor@php.rio>

Signed-off-by: Vitor Mattos <vitor@php.rio>

#8446 (comment) #8446 (comment) Signed-off-by: Vitor Mattos <vitor@php.rio>

#8446 (comment) Signed-off-by: Vitor Mattos <vitor@php.rio>

Signed-off-by: Vitor Mattos <vitor@php.rio>

* Fix tests to consider scenario of start recording when call not started Signed-off-by: Vitor Mattos <vitor@php.rio>

docs/constants.md

lib/Chat/Parser/SystemMessage.php

lib/Service/RoomService.php

tests/integration/features/bootstrap/FeatureContext.php

#8446 (comment) Signed-off-by: Vitor Mattos <vitor@php.rio>

…d the setting in the meantime. #8446 (comment) Signed-off-by: Vitor Mattos <vitor@php.rio>

Signed-off-by: Vitor Mattos <vitor@php.rio>

vitormattos added 2. developing feature: api 🛠️ OCS API for conversations, chats and participants php labels Dec 8, 2022

vitormattos added this to the 💟 Next Major (26) milestone Dec 8, 2022

vitormattos requested a review from nickvergessen December 8, 2022 03:16

vitormattos self-assigned this Dec 8, 2022

vitormattos changed the title ~~⏺ Call recording ⚒ Server API - Add capability to toggle recording - Part 2~~ ⏺ Call recording ⚒ Server API - Start/stop recording - Part 2 Dec 8, 2022

vitormattos mentioned this pull request Dec 8, 2022

⏺️ Call recording 🛠️ Server API #8326

Closed

39 tasks

nickvergessen mentioned this pull request Dec 8, 2022

⏺ Call recording ⚒ Server API - Add capability to toggle recording - Part 1 #8445

Merged

24 tasks

vitormattos force-pushed the feature/toggle-call-recording-status branch from 03a6839 to 93ac6fd Compare December 8, 2022 19:33

vitormattos added 4 commits December 9, 2022 17:02

Toggle call recording status

db88acf

Signed-off-by: Vitor Mattos <vitor@php.rio>

Remove wrong description

50e675d

Signed-off-by: Vitor Mattos <vitor@php.rio>

Fix method name

d36acdc

Signed-off-by: Vitor Mattos <vitor@php.rio>

Add system message and tests

26bba30

Signed-off-by: Vitor Mattos <vitor@php.rio>

vitormattos force-pushed the feature/toggle-call-recording-status branch from a5364b0 to 26bba30 Compare December 9, 2022 20:03

vitormattos added 3 commits December 9, 2022 17:36

Fix permission

d397645

Signed-off-by: Vitor Mattos <vitor@php.rio>

Move logic to a single place

1ace3ba

Signed-off-by: Vitor Mattos <vitor@php.rio>

Send signaling message

b090004

Signed-off-by: Vitor Mattos <vitor@php.rio>

nickvergessen reviewed Dec 9, 2022

View reviewed changes

vitormattos added 11 commits December 12, 2022 14:21

Document constants

0f179b7

Signed-off-by: Vitor Mattos <vitor@php.rio>

Moved methods of recording api to specific controller

b06786d

Signed-off-by: Vitor Mattos <vitor@php.rio>

Document new system messages

df6c971

Signed-off-by: Vitor Mattos <vitor@php.rio>

Fix var name from capability to config

bf0d81f

Signed-off-by: Vitor Mattos <vitor@php.rio>

Rename argument

56c3bbf

Signed-off-by: Vitor Mattos <vitor@php.rio>

Moved constants from RoomService.php to Room.php

9533cfd

Signed-off-by: Vitor Mattos <vitor@php.rio>

Update call recording in Room instance

a15ba91

Signed-off-by: Vitor Mattos <vitor@php.rio>

Reverted change after code review

5553d9a

https://github.com/nextcloud/spreed/pull/8446/files#r1044871679 Signed-off-by: Vitor Mattos <vitor@php.rio>

Fix English text

8fd052b

Signed-off-by: Vitor Mattos <vitor@php.rio>

Moved the logic to check if recording is enabled to service methods

1c3d218

Signed-off-by: Vitor Mattos <vitor@php.rio>

Make more specific the validation to start and stop recordin

55691b0

Signed-off-by: Vitor Mattos <vitor@php.rio>

Fixes after push

e4637c5

Signed-off-by: Vitor Mattos <vitor@php.rio>

vitormattos force-pushed the feature/toggle-call-recording-status branch from 774c03d to e4637c5 Compare December 12, 2022 22:43

nickvergessen requested changes Dec 14, 2022

View reviewed changes

vitormattos added 14 commits December 15, 2022 00:55

Return an error when the call is not activated

19a9c83

Signed-off-by: Vitor Mattos <vitor@php.rio>

Typing

8933ba4

Signed-off-by: Vitor Mattos <vitor@php.rio>

Remove call recording constatns from specific call recording group

0c82867

Signed-off-by: Vitor Mattos <vitor@php.rio>

Fix filename after renamed

36126de

Signed-off-by: Vitor Mattos <vitor@php.rio>

Fix description

704624a

Signed-off-by: Vitor Mattos <vitor@php.rio>

Add link to call recording status

6c937cf

Signed-off-by: Vitor Mattos <vitor@php.rio>

Fix English

8cf2988

#8446 (comment) Signed-off-by: Vitor Mattos <vitor@php.rio>

Remove unused property

b549128

Signed-off-by: Vitor Mattos <vitor@php.rio>

Remove unused checks

9b6ed29

#8446 (comment) #8446 (comment) Signed-off-by: Vitor Mattos <vitor@php.rio>

Replace the constant name by a better

068f120

#8446 (comment) Signed-off-by: Vitor Mattos <vitor@php.rio>

Replace hardcoded value by constant

6fa3cc8

Signed-off-by: Vitor Mattos <vitor@php.rio>

Make the code of error message more specific

c2a55aa

Signed-off-by: Vitor Mattos <vitor@php.rio>

Since in error cases it throws, no need to return anything on success.

0e08623

Signed-off-by: Vitor Mattos <vitor@php.rio>

Simplify the logic

e285979

Signed-off-by: Vitor Mattos <vitor@php.rio>

vitormattos requested a review from nickvergessen December 15, 2022 04:27

* Test responses of recording API

5c02e5e

* Fix tests to consider scenario of start recording when call not started Signed-off-by: Vitor Mattos <vitor@php.rio>

nickvergessen reviewed Dec 15, 2022

View reviewed changes

docs/constants.md Outdated Show resolved Hide resolved

lib/Chat/Parser/SystemMessage.php Outdated Show resolved Hide resolved

lib/Service/RoomService.php Outdated Show resolved Hide resolved

tests/integration/features/bootstrap/FeatureContext.php Outdated Show resolved Hide resolved

vitormattos added 4 commits December 15, 2022 22:16

Fix English

34f691b

#8446 (comment) Signed-off-by: Vitor Mattos <vitor@php.rio>

Make more clear

1e3f332

#8446 (comment) Signed-off-by: Vitor Mattos <vitor@php.rio>

We should always allow to end the recording, even if the admin change…

b77c4e8

…d the setting in the meantime. #8446 (comment) Signed-off-by: Vitor Mattos <vitor@php.rio>

Replace generic match of json by specific using the error code

a1f3135

Signed-off-by: Vitor Mattos <vitor@php.rio>

vitormattos requested a review from nickvergessen December 16, 2022 01:29

nickvergessen approved these changes Dec 16, 2022

View reviewed changes

nickvergessen added 3. to review and removed 2. developing labels Dec 16, 2022

nickvergessen merged commit da1376b into master Dec 16, 2022

nickvergessen deleted the feature/toggle-call-recording-status branch December 16, 2022 11:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

⏺ Call recording ⚒ Server API - Start/stop recording - Part 2 #8446

⏺ Call recording ⚒ Server API - Start/stop recording - Part 2 #8446

vitormattos commented Dec 8, 2022 •

edited

nickvergessen left a comment

⏺ Call recording ⚒ Server API - Start/stop recording - Part 2 #8446

⏺ Call recording ⚒ Server API - Start/stop recording - Part 2 #8446

Conversation

vitormattos commented Dec 8, 2022 • edited

🚧 TODO

🏁 Checklist

nickvergessen left a comment

Choose a reason for hiding this comment

vitormattos commented Dec 8, 2022 •

edited