Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⏺ Call recording ⚒ Server API - Add capability to toggle recording - Part 1 #8445

Merged
merged 5 commits into from
Dec 9, 2022
Merged

⏺ Call recording ⚒ Server API - Add capability to toggle recording - Part 1 #8445

merged 5 commits into from
Dec 9, 2022

Conversation

vitormattos
Copy link
Contributor

@vitormattos vitormattos commented Dec 8, 2022 •
edited by nickvergessen
Loading

Ref #8326

🚧 TODO

  • Document the system messages
    • recording_started
    • recording_stopped
    • audio_recording_started (Unsure if we implement this)
    • audio_recording_stopped (Unsure if we implement this)
  • [ Document room API attribute for "call started at time" (activeSince of the room object) - suggestion: callStartTime https://github.com/Add callStartTime to room API #8369
  • Document room API attribute for "the call is being recorded"
    • callRecording - int
      • 0 none
      • 1 video
      • 2 audio (Unsure if we implement this)
    • Document above constants in docs/constants.md
  • Document config capability whether recordings are on/off
    • config => call => recording (bool)
  • Document capability for recording version
    • recording-v1
  • Document API endpoint to start a recording
  • Document API endpoint to stop a recording

🏁 Checklist

@vitormattos vitormattos marked this pull request as ready for review December 8, 2022 01:19
@vitormattos vitormattos added 3. to review feature: api 🛠️ OCS API for conversations, chats and participants php labels Dec 8, 2022
@vitormattos vitormattos added this to the 💟 Next Major (26) milestone Dec 8, 2022
@vitormattos vitormattos mentioned this pull request Dec 8, 2022
Closed
39 tasks
@vitormattos vitormattos changed the title Add capability to toggle recording Call recording hammer_and_wrench Server API - Add capability to toggle recording - Part 1 Dec 8, 2022
@vitormattos vitormattos changed the title Call recording hammer_and_wrench Server API - Add capability to toggle recording - Part 1 Call recording ⚒ Server API - Add capability to toggle recording - Part 1 Dec 8, 2022
@vitormattos vitormattos changed the title Call recording ⚒ Server API - Add capability to toggle recording - Part 1 ⏺ Call recording ⚒ Server API - Add capability to toggle recording - Part 1 Dec 8, 2022
nickvergessen
nickvergessen requested changes Dec 8, 2022
View reviewed changes
lib/Config.php Outdated Show resolved Hide resolved
lib/Capabilities.php Outdated Show resolved Hide resolved
nickvergessen
nickvergessen reviewed Dec 8, 2022
View reviewed changes
lib/Capabilities.php Outdated Show resolved Hide resolved
lib/Config.php Outdated Show resolved Hide resolved
@vitormattos
Add capability to toggle recording
2642ca8 
Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos
Split recording capability
474bc35 
Now we have a hard capability called recording-v1 and a switable capability
by config called recording

Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos
Split record capability in feature and config
a8b0d2d 
Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos
Set call_recording enabled by default
ae2bbc2 
Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos vitormattos force-pushed the feature/add-capability-to-toggle-recording branch from 1479243 to ae2bbc2 Compare December 8, 2022 14:06
@vitormattos vitormattos mentioned this pull request Dec 8, 2022
Merged
7 tasks
@nickvergessen
Minor things
630924f 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit edb7df0 into master Dec 9, 2022
@nickvergessen nickvergessen deleted the feature/add-capability-to-toggle-recording branch December 9, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees
No one assigned
Labels
4. to release feature: api 🛠️ OCS API for conversations, chats and participants php
Projects
None yet
Milestone
v16.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@vitormattos @nickvergessen