Limit unread message counter to "99+" #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
3. to review
backport-request
bug
design
feature: chat 💬
danxuliu
reviewed
May 3, 2018
| @@ -103,7 +103,8 @@ | |||
| templateContext: function() { | |||
| return { | |||
| isDeletable: (this.model.get('participantType') === 1 || this.model.get('participantType') === 2) && | |||
| (Object.keys(this.model.get('participants')).length > 1 || this.model.get('numGuests') > 0) | |||
| (Object.keys(this.model.get('participants')).length > 1 || this.model.get('numGuests') > 0), | |||
| numUnreadMessages: this.model.get('unreadMessages') > 99 ? '99+' : this.model.get('unreadMessages') | |||
There was a problem hiding this comment.
I think that the 99+ should be internationalized, as a different string could be needed (although I am not really sure) in languages that do not use Hindu-Arabic numerals or the plus sign.
There was a problem hiding this comment.
I quickly thought about it too, but I wouldn't know which language does not use + for +? :D
lets keep it until someone complains.
Ivansss
approved these changes
May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS is a copy of the server version now
Top is new (84445 is now 99+)
Bottom is old (number is cut off)
As per documentation https://docs.nextcloud.com/server/13/developer_manual/design/navigation.html#counter the counter should be limited to 3 digits, but I think for chat messages it does not matter anymore when it's over 100, so we display 99+ when it's more then 99
@Ivansss @mario we limit the number in the UI not the api, so maybe you can limit it too to 99+