Fix call view not visible when joining a call again in Files app #8498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a call is joined all the direct child elements of the header are hidden by adding a special CSS class, "hidden-by-call", and then the call view is added to the header. When the call is left the "hidden-by-call" class is removed and the call view is moved back to its original parent. That parent was ".app-sidebar-header__action", but in nextcloud/vue 3.3.0 (Nextcloud 22) it was renamed to "app-sidebar-header__description". As the expected parent did not exist the call view was not moved back and instead stayed as a direct child of the header, so when a call was joined again "hidden-by-call" was also added to the call view and therefore hid it like the other elements. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
3. to review
bug
feature: frontend 🖌️
|
/backport to stable25 |
|
/backport to stable24 |
nickvergessen
deleted the
fix-call-view-not-visible-when-joining-a-call-again-in-files-app
branch
This was referenced Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a call is joined all the direct child elements of the header are hidden by adding a special CSS class,
hidden-by-call, and then the call view is added to the header. When the call is left thehidden-by-callclass is removed and the call view is moved back to its original parent. That parent was.app-sidebar-header__action, but in nextcloud/vue 3.3.0 (Nextcloud 22) it was renamed toapp-sidebar-header__description.As the expected parent did not exist the call view was not moved back and instead stayed as a direct child of the header, so when the call was joined again
hidden-by-callwas also added to the call view and therefore hid it like the other elements.How to test
Results with this pull request
The call view is visible.
Results without this pull request
The call view is not visible.