Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable24] Fix call view not visible when joining a call again in Files app #8508

Merged
merged 1 commit into from Jan 2, 2023
Merged

[stable24] Fix call view not visible when joining a call again in Files app #8508

merged 1 commit into from Jan 2, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #8498

@danxuliu @backportbot-nextcloud
Fix call view not visible when joining a call again in Files app
39d2a1c 
When a call is joined all the direct child elements of the header are
hidden by adding a special CSS class, "hidden-by-call", and then the
call view is added to the header. When the call is left the
"hidden-by-call" class is removed and the call view is moved back to
its original parent. That parent was ".app-sidebar-header__action", but
in nextcloud/vue 3.3.0 (Nextcloud 22) it was renamed to
"app-sidebar-header__description".

As the expected parent did not exist the call view was not moved back
and instead stayed as a direct child of the header, so when a call was
joined again "hidden-by-call" was also added to the call view and
therefore hid it like the other elements.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@backportbot-nextcloud backportbot-nextcloud bot added bug feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents labels Jan 2, 2023
@backportbot-nextcloud backportbot-nextcloud bot added this to the 💛 Next Patch (24) milestone Jan 2, 2023
@nickvergessen nickvergessen merged commit f04461a into stable24 Jan 2, 2023
@nickvergessen nickvergessen deleted the backport/8498/stable24 branch January 2, 2023 08:36
@nickvergessen nickvergessen mentioned this pull request Jan 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees
No one assigned
Labels
4. to release bug feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents
Projects
None yet
Milestone
v14.0.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nickvergessen @danxuliu