Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show index page instead of hard redirect to 404 on chat delete after signaling error #9054

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Mar 13, 2023

A problem

  1. Open a chat
  2. Delete the opened chat

Expected behavior

Chat is not open.

Actual behavior

After successful deleting, a web-page received a signaling error and redirect to not-found with a page reload.

πŸ–ΌοΈ Screenshots

🏚️ Before

1.mp4

🏑 After

2.mp4

🚧 TODO

  • leave room after successful deletion
  • Stop waiting for new messages from removed chat
  • Push navigation to the root page

🏁 Checklist

Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
@Antreesy Antreesy merged commit 95c1cba into master Mar 14, 2023
@Antreesy Antreesy deleted the fix/noid/fix-chat-removing-redirect branch March 14, 2023 09:13
@Antreesy
Copy link
Contributor

/backport to stable26

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants