Flatten left sidebar nested lists

[marcoambrosini]

No description provided.

[nickvergessen]

What's the target date with this? It will "break" very soon if anyone touches the involved files

[nickvergessen]

Conflicting files
src/components/LeftSidebar/LeftSidebar.vue

[Antreesy]

Shouldn't be order of conversations checked and tested for this component here and in other places?
Suitable places, in my opinion:

• initial render (list and search list)
• after list refetching
• after lastActivity changing
• after new conversation creating
• with favorite conversations (1 and more)

I guess, they come from server in the right order, so we could emulate it with:

const sortedConversationList = conversationsList.slice().sort((a, b) => a.lastActivity - b.lastActivity)

and test like this:

conversationArray.wrappers.forEach((conversation, index) => {
    expect(conversation.props('displayName').toBe(sortedConversationList[index].displayName)
}

Please check if it works properly, i didn't test it
Would be nice to hear @ShGKme opinion on this

[Antreesy]

Add some fixes in commits below

[ShGKme]

Works fine after the last rebase and flattened. Tested with different searches, mentions, unread notifications, refreshing, on mobile.

There are things to refactor, but we may do it late, as it is urgent and refactoring is not the purpose of the PR.

[Antreesy]

/backport to stable26

⚠️ master branch have some changes from #9054 in ConversationList.vue that needs to be approved

[backportbot-nextcloud]

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[Antreesy]

Need to be added after #9058 approval

[ShGKme]

Nice catch!

#9058 is a backport, so it should be fixed anyway.

[Antreesy]

Sadly, but no. It's a copied method from deleted file. Patched this in backport already

[ShGKme]

Should we also remove branches:

• https://github.com/nextcloud/spreed/tree/feature/noid/flatten-conversations-list
• https://github.com/nextcloud/spreed/tree/feature/noid/flatten-conversations-list-2--fix
  ?