Fix name not shown for registered users without microphone nor camera #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the peer is a registered user her name is shown when a stream is added for that peer. However, if the peer has no microphone nor camera then no stream is added, and thus the name was not shown. Now the name is shown too when the connection is established to guarantee that it will be shown even if no stream is added. In the case of guest users the name is shown when a stream is added for that peer, but also when a "nickChanged" message is received. That message is sent when the peers are connected, so the name of the guest user was already properly set even if the user has no microphone nor camera. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
nickvergessen
approved these changes
Jun 21, 2018
nickvergessen
deleted the
fix-name-not-shown-for-registered-users-without-microphone-nor-camera
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the peer is a registered user her name is shown when a stream is added for that peer. However, if the peer has no microphone nor camera then no stream is added, and thus the name was not shown. Now the name is shown too when the connection is established to guarantee that it will be shown even if no stream is added.
In the case of guest users the name is shown when a stream is added for that peer, but also when a
nickChangedmessage is received. That message is sent when the peers are connected, so the name of the guest user was already properly set even if the user has no microphone nor camera.How to test:
Expected result
The display name of user B appears below her avatar in user A's screen
Actual result
User B's name does not appear in user A's screen