-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add backend for new user/group column #1090
base: main
Are you sure you want to change the base?
Conversation
232b63c
to
731c09b
Compare
0be010b
to
654df3a
Compare
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
e51cca5
to
924dbb7
Compare
5af9d74
to
06f0546
Compare
5d0404e
to
30adf50
Compare
06f0546
to
e514050
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First glance looks good, have not tested myself yet
- Integration test can be extended around inserting, modifying and delete column values
- a new migration class is needed to add the new columns on existing installations (existing steps are not executed again).
$rowValues[$compositeKey] = [$value]; | ||
} | ||
} else { | ||
$rowValues[$compositeKey] = $value; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it be easier to have just one common format, with the array as above? Or would it be somehow backwards-incompatible or require too many unrelated changes elsewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have one common format. But other column types aren't arrays and I think it would take many changes to make them as such.
|
||
class UsergroupColumnQB extends SuperColumnQB implements IColumnTypeQB { | ||
public function passSearchValue(IQueryBuilder $qb, string $unformattedSearchValue, string $operator, string $searchValuePlaceHolder): void { | ||
// TODO how to handle searching for multiple users/groups? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean, if multiple users/groups are part of the search string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. But I guess we can consider this later on
ef7e9f2
to
87e80be
Compare
48d1010
to
f527f99
Compare
e514050
to
b2092af
Compare
d07cbe5
to
5c276de
Compare
5c276de
to
d07cbe5
Compare
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
d07cbe5
to
23cf5fb
Compare
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Not sure what this entails. Do we already have this for other column types? @blizzz |
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
I think you already covert inserting with a user. Then there are some tests in Apiv1 on modification, e.g.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick, otherwise the recent changes look good, have to test yet.
]); | ||
} | ||
return $schema; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | |
} | |
return null; |
Contributes to #586
This adds to the backend to support adding a new column that receives users or groups.
We expect the row values of this column to be array of objects with format
{id: string, type: int}
Creating a column
Request
Result