-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add backend for new user/group column #1090
Open
enjeck
wants to merge
10
commits into
main
Choose a base branch
from
new-usergroup-column
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7223f0c
feat: add new column for user and group to backend
enjeck d1c2643
fix: phpunit test
enjeck b85007b
tests: add integration test for new column
enjeck 9025a11
enh: add value_type column
enjeck 9c78afb
fix: use correct variable
enjeck 330313d
fix: update usergroup column
enjeck 3692f28
enh: modify usergroup column backend
enjeck 23cf5fb
test: update integration tests for usergroup column
enjeck 7a1501d
fix: remove usergroup column from legacy rowmapper test
enjeck 6793858
fix: add new db migration for usergroup column
enjeck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
<?php | ||
|
||
/** @noinspection PhpUnused */ | ||
|
||
declare(strict_types=1); | ||
|
||
namespace OCA\Tables\Migration; | ||
|
||
use Closure; | ||
use OCP\DB\Exception; | ||
use OCP\DB\ISchemaWrapper; | ||
use OCP\DB\Types; | ||
use OCP\Migration\IOutput; | ||
use OCP\Migration\SimpleMigrationStep; | ||
|
||
class Version001000Date20240712000000 extends SimpleMigrationStep { | ||
/** | ||
* @param IOutput $output | ||
* @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper` | ||
* @param array $options | ||
* @return null|ISchemaWrapper | ||
Check failure on line 21 in lib/Migration/Version001000Date20240712000000.php
|
||
* @throws Exception | ||
*/ | ||
public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper { | ||
/** @var ISchemaWrapper $schema */ | ||
$schema = $schemaClosure(); | ||
|
||
if ($schema->hasTable('tables_tables')) { | ||
$table = $schema->getTable('tables_tables'); | ||
if (!$table->hasColumn('usergroup_default')) { | ||
$table->addColumn('usergroup_default', Types::TEXT, [ | ||
'notnull' => false, | ||
]); | ||
} | ||
if (!$table->hasColumn('usergroup_multiple_items')) { | ||
$table->addColumn('usergroup_multiple_items', Types::BOOLEAN, [ | ||
'notnull' => false, | ||
'default' => 0, | ||
]); | ||
} | ||
if (!$table->hasColumn('usergroup_select_users')) { | ||
$table->addColumn('usergroup_select_users', Types::BOOLEAN, [ | ||
'notnull' => false, | ||
'default' => 0, | ||
]); | ||
} | ||
if (!$table->hasColumn('usergroup_select_groups')) { | ||
$table->addColumn('usergroup_select_groups', Types::BOOLEAN, [ | ||
'notnull' => false, | ||
'default' => 0, | ||
]); | ||
} | ||
if (!$table->hasColumn('show_user_status')) { | ||
$table->addColumn('show_user_status', Types::BOOLEAN, [ | ||
'notnull' => false, | ||
'default' => 0, | ||
]); | ||
} | ||
return $schema; | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.