fix: add aria-label to NcSelect #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
|
Please also try to fill relevant info in the github sidebar and request reviewers :) |
|
I guess we also want a backport? :) |
juliushaertl
approved these changes
Jun 17, 2024
|
/backport to stable0.7 |
|
The backport to # Switch to the target branch and update it
git checkout stable0.7
git pull origin stable0.7
# Create the new backport branch
git checkout -b backport/1148/stable0.7
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1c8d88f5
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1148/stable0.7Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
We don't have pagination in stable 0.7, so can't backport this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's good for accessibility if the
NcSelectcomponent has an aria-label.Plus, this fixes the error in the console:
Console Error
vue.runtime.esm.js:4625 [Vue warn]: [NcSelect] An `inputLabel` or `ariaLabelCombobox` should be set. If an external label is used, `labelOutside` should be set to `true`. found in ---> at src/shared/components/ncTable/sections/CustomTable.vue at src/shared/components/ncTable/NcTable.vue at src/modules/main/partials/TableView.vue at src/modules/main/sections/DataTable.vue at src/modules/main/sections/TableWrapper.vue at src/pages/Context.vue at src/App.vue