Extract selection option labels for Analytics #877
Conversation
|
@Rello Hi! Are you still working on this? |
|
Hi @juliushaertl you think we can merge this? |
|
I am afraid this has potential to be breaking potential existing API use cases. I suppose the IDs of the selection can be fetched already (did not double check). Not that the output is much documented. There is a conflict btw. If we merge, it's better to have the commits squashed. |
|
@blizzz what do you suggest? I think of skipping this and simply ship the datasources for everything with Analytics itself. Kind of double work because local duplication of the API logic might be required in many places. but not impacting other apps suggestion? |
|
as discussed with @blizzz |
| return ['header' => $header, 'dimensions' => array_slice($header, 0, count($header) - 1), 'data' => $data, //'rawdata' => $data, | ||
| 'error' => 0,]; |
There was a problem hiding this comment.
Nitpick-as-a-Service: indentation looks odd. Would be better in the previous style.
There was a problem hiding this comment.
let me check which code styler setting messed this up
There was a problem hiding this comment.
saw to late. but a follow up pr is welcomed.
when column type selection is used, the datasource needs the labels, and not the internal ids Signed-off-by: Rello <Rello@users.noreply.github.com>
blizzz
added
4. to release
|
/backport to stable0.7 |
when column type selection is used, the API needs to deliver the labels, and not the internal ids
fixes Integration with NC Tables Rello/analytics#385
Using lib/Analytics (and not lib/Datasource) for better readability
Adopting from LegacyRow to Row