Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Integration): add contexts related tests #970

Merged
merged 8 commits into from
Apr 29, 2024

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Apr 8, 2024

This PR includes some foundations for Context integration tests and a couple of create and read scenarios, plus some smaller fixes.

Let's got with this and add more scenarios in follow-ups. I'll open an overview issue.

Scenarios covered

Creation

  • Create context with views and tables
  • Create context with inaccessible table
  • Create context with inaccessible view

Reading

  • Read all contexts
  • Read specific owned context
  • Read inaccessible context
  • Read a non-existing context

Small bug fixes included

  • ensure that node parameters are treated as integer values
  • report node permissions on creation
  • normalization of page result format
  • atomic handling of DB inserts on create + error handling + openapi update

@blizzz blizzz added the 2. developing Work in progress label Apr 8, 2024
@blizzz blizzz force-pushed the enh/noid/context-integration branch 5 times, most recently from 5a9943c to 4a03551 Compare April 11, 2024 15:23
@blizzz blizzz force-pushed the enh/noid/context-integration branch 2 times, most recently from 4ee4566 to b581b51 Compare April 15, 2024 16:33
@blizzz blizzz force-pushed the enh/noid/context-integration branch 2 times, most recently from 5f6d560 to 06a4672 Compare April 22, 2024 15:17
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
- that is on adding nodes to a context via API
- also sets permissions to a sensible default if not provided

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the enh/noid/context-integration branch 3 times, most recently from fc22a8d to 7f852aa Compare April 25, 2024 10:43
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the enh/noid/context-integration branch 4 times, most recently from 9f28016 to 32e4572 Compare April 26, 2024 09:17
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the enh/noid/context-integration branch 2 times, most recently from f0cca8c to 75ecf90 Compare April 26, 2024 10:11
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the enh/noid/context-integration branch from 75ecf90 to 5a1ca5e Compare April 26, 2024 10:18
@blizzz blizzz requested a review from enjeck April 26, 2024 10:25
@blizzz blizzz added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 26, 2024
@blizzz blizzz marked this pull request as ready for review April 26, 2024 10:25
@blizzz
Copy link
Member Author

blizzz commented Apr 29, 2024

/backport to stable0.7

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Apr 29, 2024
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to isolate the stored results with the collection manager 👍

@blizzz
Copy link
Member Author

blizzz commented Apr 29, 2024

Nice to isolate the stored results with the collection manager 👍

Thx! In a distant follow up I want to move the tables and views there as well and have the FeatureContext less cluttered :)

@blizzz blizzz merged commit cc904cb into main Apr 29, 2024
59 checks passed
@blizzz blizzz deleted the enh/noid/context-integration branch April 29, 2024 12:00
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants