-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(Integration): add contexts related tests #970
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
force-pushed
the
enh/noid/context-integration
branch
5 times, most recently
from
April 11, 2024 15:23
5a9943c
to
4a03551
Compare
blizzz
force-pushed
the
enh/noid/context-integration
branch
2 times, most recently
from
April 15, 2024 16:33
4ee4566
to
b581b51
Compare
blizzz
force-pushed
the
enh/noid/context-integration
branch
2 times, most recently
from
April 22, 2024 15:17
5f6d560
to
06a4672
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
- that is on adding nodes to a context via API - also sets permissions to a sensible default if not provided Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
enh/noid/context-integration
branch
3 times, most recently
from
April 25, 2024 10:43
fc22a8d
to
7f852aa
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
enh/noid/context-integration
branch
4 times, most recently
from
April 26, 2024 09:17
9f28016
to
32e4572
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
enh/noid/context-integration
branch
2 times, most recently
from
April 26, 2024 10:11
f0cca8c
to
75ecf90
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
enh/noid/context-integration
branch
from
April 26, 2024 10:18
75ecf90
to
5a1ca5e
Compare
blizzz
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Apr 26, 2024
48 tasks
/backport to stable0.7 |
juliushaertl
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to isolate the stored results with the collection manager 👍
Thx! In a distant follow up I want to move the tables and views there as well and have the FeatureContext less cluttered :) |
backportbot
bot
removed
the
backport-request
Pending backport by the backport-bot
label
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some foundations for Context integration tests and a couple of create and read scenarios, plus some smaller fixes.
Let's got with this and add more scenarios in follow-ups. I'll open an overview issue.
Scenarios covered
Creation
Reading
Small bug fixes included