Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency com.github.natario1:autocomplete to v1.1.0 #3929

Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 21, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.github.natario1:Autocomplete v1.1.0 -> 1.1.0 age adoption passing confidence

Release Notes

natario1/Autocomplete (com.github.natario1:Autocomplete)

v1.1.0

Any view returned by Presenters that has height = 0 after being measured, will be interpreted as a 'dismiss popup'. This can have side effects if you perform asynchronous loading and your adapter returns 0 items at first.

To avoid this, you can give the root view some minHeight, some vertical padding, or (better) have your adapter return an item (for empty or loading states). Note that you will show an empty popup even when you actually have no data, so you should take care of this.

Fixed a configuration change crash.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot added 3. to review Waiting for reviews dependencies labels May 21, 2024
@AndyScherzinger AndyScherzinger added this to the 19.1.0 milestone May 21, 2024
@AndyScherzinger AndyScherzinger merged commit ec2f0b5 into master May 21, 2024
19 of 20 checks passed
@AndyScherzinger AndyScherzinger deleted the renovate/com.github.natario1-autocomplete-1.x branch May 21, 2024 17:47
@AndyScherzinger
Copy link
Member

Merged even though it is the very same lib/version but preferred by renovate

Copy link

Codacy

Lint

TypemasterPR
Warnings8181
Errors119119

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code8484
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total114114

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3929-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant