Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency androidx.appcompat:appcompat to v1.7.0 #3944

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 29, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
androidx.appcompat:appcompat (source) 1.6.1 -> 1.7.0 age adoption passing confidence

Configuration

πŸ“… Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added 3. to review Waiting for reviews dependencies labels May 29, 2024
@renovate renovate bot force-pushed the renovate/androidx.appcompat-appcompat-1.x branch from 15dbdfb to 9f53f22 Compare June 18, 2024 07:28
renovate bot and others added 3 commits June 19, 2024 17:15
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the renovate/androidx.appcompat-appcompat-1.x branch from 439a58a to 86f9a15 Compare June 19, 2024 15:15
Copy link
Contributor Author

renovate bot commented Jun 19, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link

Codacy

Lint

TypemasterPR
Warnings7990
Errors10129

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code8483
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total114113

@AndyScherzinger AndyScherzinger self-requested a review June 19, 2024 15:26
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaks MessageInput with an endless loop when opening a chat room

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3944-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@AndyScherzinger
Copy link
Member

Endless loop seems gone with latest master and this PR, hence merging

@AndyScherzinger AndyScherzinger merged commit 7ff894c into master Jul 8, 2024
20 checks passed
@AndyScherzinger AndyScherzinger deleted the renovate/androidx.appcompat-appcompat-1.x branch July 8, 2024 07:48
@AndyScherzinger AndyScherzinger added this to the 19.1.0 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant