Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies #1384

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Dependencies #1384

merged 3 commits into from
Oct 30, 2023

Conversation

RomanPodymov
Copy link
Contributor

Hello.
Thank you for talk-ios.
Updated dependencies.

Signed-off-by: Roman Podymov <podymfrombryansk@yandex.com>
Signed-off-by: Roman Podymov <podymfrombryansk@yandex.com>
@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@Ivansss
Copy link
Member

Ivansss commented Oct 30, 2023

Thanks a lot for your contribution @RomanPodymov :)
We are thinking about moving to Alamofire since AFNetworking is deprecated, because of that we are wondering if there's a particular reason for bumping the library from v3 to v4? If not, we would prefer to stay at version 3 for the time being.
We would be happy to add the rest of the changes from your PR.

@RomanPodymov
Copy link
Contributor Author

Thanks a lot for your contribution @RomanPodymov :) We are thinking about moving to Alamofire since AFNetworking is deprecated, because of that we are wondering if there's a particular reason for bumping the library from v3 to v4? If not, we would prefer to stay at version 3 for the time being. We would be happy to add the rest of the changes from your PR.

Hello @Ivansss
Reverted AFNetworking.

@Ivansss Ivansss merged commit 39c8060 into nextcloud:master Oct 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants