Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort order icons for up and down are not correctly colored in dark mode #1288

Closed
raimund-schluessler opened this issue Oct 14, 2020 · 1 comment · Fixed by #1289
Closed

Sort order icons for up and down are not correctly colored in dark mode #1288

raimund-schluessler opened this issue Oct 14, 2020 · 1 comment · Fixed by #1289
Labels
bug design
Milestone
0.13.5

Comments

@raimund-schluessler
Copy link
Member

raimund-schluessler commented Oct 14, 2020 •
edited

The sort order icons for sorting up or down are still black in dark mode. This is a bit weird, since they are handled exactly the same as the normal icons, which are correct.

Screenshot_2020-10-14 Aufgaben - Nextcloud
@raimund-schluessler raimund-schluessler added this to the 0.13.5 milestone Oct 14, 2020
@raimund-schluessler
Copy link
Member Author

I have no idea why, but the two underscores in the icon names screw up the dark theme. This @include icon-black-white('start__up', 'tasks', 1); does not work, this @include icon-black-white('start-up', 'tasks', 1); does. @skjnldsv Maybe any idea why?

@raimund-schluessler raimund-schluessler mentioned this issue Oct 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug design
Projects
None yet
Milestone
0.13.5
Development

Successfully merging a pull request may close this issue.

Fix the sort order icons when using dark theme nextcloud/tasks
1 participant
@raimund-schluessler