Fix the sort order icons when using dark theme #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schl眉脽ler <raimund.schluessler@mailbox.org>
Codecov Report
@@ Coverage Diff @@
## master #1289 +/- ##
==========================================
- Coverage 27.72% 27.67% -0.06%
==========================================
Files 47 47
Lines 2658 2656 -2
Branches 507 505 -2
==========================================
- Hits 737 735 -2
Misses 1779 1779
Partials 142 142 |
Signed-off-by: Raimund Schl眉脽ler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
fix/1288/order-icons-dark
branch
from
724c1a4
to
4f733d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, the double underscore in the icon names breaks the dark theme CSS generation for some reason. 馃し
Closes #1288.