Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing newly created task fails #233

Closed
raimund-schluessler opened this issue Jan 26, 2019 · 13 comments
Closed

Editing newly created task fails #233

raimund-schluessler opened this issue Jan 26, 2019 · 13 comments

Comments

@raimund-schluessler
Copy link
Member

raimund-schluessler commented Jan 26, 2019

Steps to reproduce

  1. Use current master 8e98e3f
  2. Create a new task.
  3. Edit it (e.g. complete it, star it, set anything) --> First request succeeds.
  4. Edit it again --> This request will fail with 412 Precondition failed.

Expected behaviour

Editing a newly created task should work flawlessly, not matter how often you edit.

Actual behaviour

The second request will fail with 412 Precondition failed.

I will give details to the requests and what was send later (the etag is missing or wrong). Maybe @skjnldsv and @georgehrke Could have a look already.

Edit: I will check if X-Sabre-Ew-Gross: iCalendar validation warning: PRODID MUST appear exactly once in a VCALENDAR component is the reason.

Edit2: Yes, this was the problem.

Creating request (inquiry header):

XHRPUThttp://192.168.56.2/nextcloud/remote.php/dav/calendars/admin/tasksonly/28D35DC6-8A8A-4947-8981-88666A21C67A.ics[HTTP/1.1 201 Created 199ms] 
KopfzeilenCookiesParameterAntwortZeitAufruflisteAngefragte Adresse:Anfragemethode:Externe Adresse:Status-Code:201Bearbeiten und erneut sendenKopfzeilen (unformatiert)Version:Anfragekopfzeilen:Host: 192.168.56.2
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0
Accept: */*
Accept-Language: de,en-US;q=0.7,en;q=0.3
Accept-Encoding: gzip, deflate
X-Requested-With: XMLHttpRequest
requesttoken: 2n1bYMeQ6paa+cIQNGLMBqaXpGWv8JqILZsS2XLquBs=:ijoLBa/kouH0lYl6VVqcNtzUygedx/CndKtwnjSr/Eg=
Depth: 0
Content-Type: text/calendar; charset=utf-8
Content-Length: 206
Connection: keep-alive
Cookie: nc_sameSiteCookielax=true; nc_sameSiteCookiestrict=true; oc_sessionPassphrase=YHp76hadQQ5iXHPhtambAoGiWC67H8FH66wxYV0jxWKmWrMzp919ysVBWTZaIPOJ2c3QuGkKLyN6eEEGSn5J%2FWNeyJCKwhSUG1udvbXMm2GuSASPbp%2FKpYPPIM95lik4; ocbrb85g3rfg=vbttf5o4bn06e66ptbf2vq6tn5; nc_username=admin; nc_token=QH3MO9yKhF9jYmxcaKzX9HSwrFoq0UVJ; nc_session_id=vbttf5o4bn06e66ptbf2vq6tn5Antwortkopfzeilen:HTTP/1.1 201 Created
Date: Sat, 26 Jan 2019 08:11:33 GMT
Server: Apache/2.4.25 (Debian)
Expires: Thu, 19 Nov 1981 08:52:00 GMT
Cache-Control: no-store, no-cache, must-revalidate
Pragma: no-cache
Content-Security-Policy: default-src 'none';
X-Frame-Options: SAMEORIGIN
X-XSS-Protection: 1; mode=block
X-Content-Type-Options: nosniff
X-Robots-Tag: none
X-Download-Options: noopen
X-Permitted-Cross-Domain-Policies: none
Referrer-Policy: no-referrer
X-Sabre-Ew-Gross: iCalendar validation warning: PRODID MUST appear exactly once in a VCALENDAR component
Content-Length: 0
Keep-Alive: timeout=5, max=100
Connection: Keep-Alive
Content-Type: text/html; charset=UTF-8Antwortkopfzeilen (684 B)Cache-Controlno-store, no-cache, must-revalidateConnectionKeep-AliveContent-Length0Content-Security-Policydefault-src 'none';Content-Typetext/html; charset=UTF-8DateSat, 26 Jan 2019 08:11:33 GMTExpiresThu, 19 Nov 1981 08:52:00 GMTKeep-Alivetimeout=5, max=100Pragmano-cacheReferrer-Policyno-referrerServerApache/2.4.25 (Debian)X-Content-Type-OptionsnosniffX-Download-OptionsnoopenX-Frame-OptionsSAMEORIGINX-Permitted-Cross-Domain-PoliciesnoneX-Robots-TagnoneX-Sabre-Ew-GrossiCalendar validation warning: …once in a VCALENDAR componentX-XSS-Protection1; mode=blockAnfragekopfzeilen (911 B)Accept*/*Accept-Encodinggzip, deflateAccept-Languagede,en-US;q=0.7,en;q=0.3Connectionkeep-aliveContent-Length206Content-Typetext/calendar; charset=utf-8Cookienc_sameSiteCookielax=true; nc_…id=vbttf5o4bn06e66ptbf2vq6tn5Depth0Host192.168.56.2requesttoken2n1bYMeQ6paa+cIQNGLMBqaXpGWv8J…6VVqcNtzUygedx/CndKtwnjSr/Eg=User-AgentMozilla/5.0 (Windows NT 10.0; …) Gecko/20100101 Firefox/64.0X-Requested-WithXMLHttpRequest

Creating request (response header):

XHRPUThttp://192.168.56.2/nextcloud/remote.php/dav/calendars/admin/tasksonly/28D35DC6-8A8A-4947-8981-88666A21C67A.ics[HTTP/1.1 201 Created 199ms] 
KopfzeilenCookiesParameterAntwortZeitAufruflisteAngefragte Adresse:Anfragemethode:Externe Adresse:Status-Code:201Bearbeiten und erneut sendenKopfzeilen (unformatiert)Version:Anfragekopfzeilen:Host: 192.168.56.2
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0
Accept: */*
Accept-Language: de,en-US;q=0.7,en;q=0.3
Accept-Encoding: gzip, deflate
X-Requested-With: XMLHttpRequest
requesttoken: 2n1bYMeQ6paa+cIQNGLMBqaXpGWv8JqILZsS2XLquBs=:ijoLBa/kouH0lYl6VVqcNtzUygedx/CndKtwnjSr/Eg=
Depth: 0
Content-Type: text/calendar; charset=utf-8
Content-Length: 206
Connection: keep-alive
Cookie: nc_sameSiteCookielax=true; nc_sameSiteCookiestrict=true; oc_sessionPassphrase=YHp76hadQQ5iXHPhtambAoGiWC67H8FH66wxYV0jxWKmWrMzp919ysVBWTZaIPOJ2c3QuGkKLyN6eEEGSn5J%2FWNeyJCKwhSUG1udvbXMm2GuSASPbp%2FKpYPPIM95lik4; ocbrb85g3rfg=vbttf5o4bn06e66ptbf2vq6tn5; nc_username=admin; nc_token=QH3MO9yKhF9jYmxcaKzX9HSwrFoq0UVJ; nc_session_id=vbttf5o4bn06e66ptbf2vq6tn5Antwortkopfzeilen:HTTP/1.1 201 Created
Date: Sat, 26 Jan 2019 08:11:33 GMT
Server: Apache/2.4.25 (Debian)
Expires: Thu, 19 Nov 1981 08:52:00 GMT
Cache-Control: no-store, no-cache, must-revalidate
Pragma: no-cache
Content-Security-Policy: default-src 'none';
X-Frame-Options: SAMEORIGIN
X-XSS-Protection: 1; mode=block
X-Content-Type-Options: nosniff
X-Robots-Tag: none
X-Download-Options: noopen
X-Permitted-Cross-Domain-Policies: none
Referrer-Policy: no-referrer
X-Sabre-Ew-Gross: iCalendar validation warning: PRODID MUST appear exactly once in a VCALENDAR component
Content-Length: 0
Keep-Alive: timeout=5, max=100
Connection: Keep-Alive
Content-Type: text/html; charset=UTF-8Antwortkopfzeilen (684 B)Cache-Controlno-store, no-cache, must-revalidateConnectionKeep-AliveContent-Length0Content-Security-Policydefault-src 'none';Content-Typetext/html; charset=UTF-8DateSat, 26 Jan 2019 08:11:33 GMTExpiresThu, 19 Nov 1981 08:52:00 GMTKeep-Alivetimeout=5, max=100Pragmano-cacheReferrer-Policyno-referrerServerApache/2.4.25 (Debian)X-Content-Type-OptionsnosniffX-Download-OptionsnoopenX-Frame-OptionsSAMEORIGINX-Permitted-Cross-Domain-PoliciesnoneX-Robots-TagnoneX-Sabre-Ew-GrossiCalendar validation warning: …once in a VCALENDAR componentX-XSS-Protection1; mode=blockAnfragekopfzeilen (911 B)Accept*/*Accept-Encodinggzip, deflateAccept-Languagede,en-US;q=0.7,en;q=0.3Connectionkeep-aliveContent-Length206Content-Typetext/calendar; charset=utf-8Cookienc_sameSiteCookielax=true; nc_…id=vbttf5o4bn06e66ptbf2vq6tn5Depth0Host192.168.56.2requesttoken2n1bYMeQ6paa+cIQNGLMBqaXpGWv8J…6VVqcNtzUygedx/CndKtwnjSr/Eg=User-AgentMozilla/5.0 (Windows NT 10.0; …) Gecko/20100101 Firefox/64.0X-Requested-WithXMLHttpRequest

First edit request (inquiry header):

XHRPUThttp://192.168.56.2/nextcloud/remote.php/dav/calendars/admin/tasksonly/28D35DC6-8A8A-4947-8981-88666A21C67A.ics[HTTP/1.1 204 No Content 215ms] 
KopfzeilenCookiesParameterAntwortZeitAufruflisteAngefragte Adresse:Anfragemethode:Externe Adresse:Status-Code:204Bearbeiten und erneut sendenKopfzeilen (unformatiert)Version:Anfragekopfzeilen:Host: 192.168.56.2
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0
Accept: */*
Accept-Language: de,en-US;q=0.7,en;q=0.3
Accept-Encoding: gzip, deflate
X-Requested-With: XMLHttpRequest
requesttoken: 2n1bYMeQ6paa+cIQNGLMBqaXpGWv8JqILZsS2XLquBs=:ijoLBa/kouH0lYl6VVqcNtzUygedx/CndKtwnjSr/Eg=
Depth: 0
Content-Type: application/xml; charset=utf-8
If-Match: "3fd8c175e52d953c0daa242bbacbd9c9"
Content-Length: 273
Connection: keep-alive
Cookie: nc_sameSiteCookielax=true; nc_sameSiteCookiestrict=true; oc_sessionPassphrase=YHp76hadQQ5iXHPhtambAoGiWC67H8FH66wxYV0jxWKmWrMzp919ysVBWTZaIPOJ2c3QuGkKLyN6eEEGSn5J%2FWNeyJCKwhSUG1udvbXMm2GuSASPbp%2FKpYPPIM95lik4; ocbrb85g3rfg=vbttf5o4bn06e66ptbf2vq6tn5; nc_username=admin; nc_token=QH3MO9yKhF9jYmxcaKzX9HSwrFoq0UVJ; nc_session_id=vbttf5o4bn06e66ptbf2vq6tn5Antwortkopfzeilen:HTTP/1.1 204 No Content
Date: Sat, 26 Jan 2019 08:12:39 GMT
Server: Apache/2.4.25 (Debian)
Expires: Thu, 19 Nov 1981 08:52:00 GMT
Cache-Control: no-store, no-cache, must-revalidate
Pragma: no-cache
Content-Security-Policy: default-src 'none';
X-Frame-Options: SAMEORIGIN
X-XSS-Protection: 1; mode=block
X-Content-Type-Options: nosniff
X-Robots-Tag: none
X-Download-Options: noopen
X-Permitted-Cross-Domain-Policies: none
Referrer-Policy: no-referrer
X-Sabre-Ew-Gross: iCalendar validation warning: PRODID MUST appear exactly once in a VCALENDAR component
Keep-Alive: timeout=5, max=100
Connection: Keep-Alive
Content-Type: text/html; charset=UTF-8Antwortkopfzeilen (668 B)Cache-Controlno-store, no-cache, must-revalidateConnectionKeep-AliveContent-Security-Policydefault-src 'none';Content-Typetext/html; charset=UTF-8DateSat, 26 Jan 2019 08:12:39 GMTExpiresThu, 19 Nov 1981 08:52:00 GMTKeep-Alivetimeout=5, max=100Pragmano-cacheReferrer-Policyno-referrerServerApache/2.4.25 (Debian)X-Content-Type-OptionsnosniffX-Download-OptionsnoopenX-Frame-OptionsSAMEORIGINX-Permitted-Cross-Domain-PoliciesnoneX-Robots-TagnoneX-Sabre-Ew-GrossiCalendar validation warning: …once in a VCALENDAR componentX-XSS-Protection1; mode=blockAnfragekopfzeilen (959 B)Accept*/*Accept-Encodinggzip, deflateAccept-Languagede,en-US;q=0.7,en;q=0.3Connectionkeep-aliveContent-Length273Content-Typeapplication/xml; charset=utf-8Cookienc_sameSiteCookielax=true; nc_…id=vbttf5o4bn06e66ptbf2vq6tn5Depth0Host192.168.56.2If-Match"3fd8c175e52d953c0daa242bbacbd9c9"requesttoken2n1bYMeQ6paa+cIQNGLMBqaXpGWv8J…6VVqcNtzUygedx/CndKtwnjSr/Eg=User-AgentMozilla/5.0 (Windows NT 10.0; …) Gecko/20100101 Firefox/64.0X-Requested-WithXMLHttpRequest

First editing request (response header):

XHRPUThttp://192.168.56.2/nextcloud/remote.php/dav/calendars/admin/tasksonly/28D35DC6-8A8A-4947-8981-88666A21C67A.ics[HTTP/1.1 204 No Content 215ms] 
KopfzeilenCookiesParameterAntwortZeitAufruflisteAngefragte Adresse:Anfragemethode:Externe Adresse:Status-Code:204Bearbeiten und erneut sendenKopfzeilen (unformatiert)Version:Anfragekopfzeilen:Host: 192.168.56.2
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0
Accept: */*
Accept-Language: de,en-US;q=0.7,en;q=0.3
Accept-Encoding: gzip, deflate
X-Requested-With: XMLHttpRequest
requesttoken: 2n1bYMeQ6paa+cIQNGLMBqaXpGWv8JqILZsS2XLquBs=:ijoLBa/kouH0lYl6VVqcNtzUygedx/CndKtwnjSr/Eg=
Depth: 0
Content-Type: application/xml; charset=utf-8
If-Match: "3fd8c175e52d953c0daa242bbacbd9c9"
Content-Length: 273
Connection: keep-alive
Cookie: nc_sameSiteCookielax=true; nc_sameSiteCookiestrict=true; oc_sessionPassphrase=YHp76hadQQ5iXHPhtambAoGiWC67H8FH66wxYV0jxWKmWrMzp919ysVBWTZaIPOJ2c3QuGkKLyN6eEEGSn5J%2FWNeyJCKwhSUG1udvbXMm2GuSASPbp%2FKpYPPIM95lik4; ocbrb85g3rfg=vbttf5o4bn06e66ptbf2vq6tn5; nc_username=admin; nc_token=QH3MO9yKhF9jYmxcaKzX9HSwrFoq0UVJ; nc_session_id=vbttf5o4bn06e66ptbf2vq6tn5Antwortkopfzeilen:HTTP/1.1 204 No Content
Date: Sat, 26 Jan 2019 08:12:39 GMT
Server: Apache/2.4.25 (Debian)
Expires: Thu, 19 Nov 1981 08:52:00 GMT
Cache-Control: no-store, no-cache, must-revalidate
Pragma: no-cache
Content-Security-Policy: default-src 'none';
X-Frame-Options: SAMEORIGIN
X-XSS-Protection: 1; mode=block
X-Content-Type-Options: nosniff
X-Robots-Tag: none
X-Download-Options: noopen
X-Permitted-Cross-Domain-Policies: none
Referrer-Policy: no-referrer
X-Sabre-Ew-Gross: iCalendar validation warning: PRODID MUST appear exactly once in a VCALENDAR component
Keep-Alive: timeout=5, max=100
Connection: Keep-Alive
Content-Type: text/html; charset=UTF-8Antwortkopfzeilen (668 B)Cache-Controlno-store, no-cache, must-revalidateConnectionKeep-AliveContent-Security-Policydefault-src 'none';Content-Typetext/html; charset=UTF-8DateSat, 26 Jan 2019 08:12:39 GMTExpiresThu, 19 Nov 1981 08:52:00 GMTKeep-Alivetimeout=5, max=100Pragmano-cacheReferrer-Policyno-referrerServerApache/2.4.25 (Debian)X-Content-Type-OptionsnosniffX-Download-OptionsnoopenX-Frame-OptionsSAMEORIGINX-Permitted-Cross-Domain-PoliciesnoneX-Robots-TagnoneX-Sabre-Ew-GrossiCalendar validation warning: …once in a VCALENDAR componentX-XSS-Protection1; mode=blockAnfragekopfzeilen (959 B)Accept*/*Accept-Encodinggzip, deflateAccept-Languagede,en-US;q=0.7,en;q=0.3Connectionkeep-aliveContent-Length273Content-Typeapplication/xml; charset=utf-8Cookienc_sameSiteCookielax=true; nc_…id=vbttf5o4bn06e66ptbf2vq6tn5Depth0Host192.168.56.2If-Match"3fd8c175e52d953c0daa242bbacbd9c9"requesttoken2n1bYMeQ6paa+cIQNGLMBqaXpGWv8J…6VVqcNtzUygedx/CndKtwnjSr/Eg=User-AgentMozilla/5.0 (Windows NT 10.0; …) Gecko/20100101 Firefox/64.0X-Requested-WithXMLHttpRequest

Second editing request (inquiry header):

XHRPUThttp://192.168.56.2/nextcloud/remote.php/dav/calendars/admin/tasksonly/28D35DC6-8A8A-4947-8981-88666A21C67A.ics[HTTP/1.1 412 Precondition failed 131ms] 
KopfzeilenCookiesParameterAntwortZeitAufruflisteAngefragte Adresse:Anfragemethode:Externe Adresse:Status-Code:412Bearbeiten und erneut sendenKopfzeilen (unformatiert)Version:Anfragekopfzeilen:Host: 192.168.56.2
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0
Accept: */*
Accept-Language: de,en-US;q=0.7,en;q=0.3
Accept-Encoding: gzip, deflate
X-Requested-With: XMLHttpRequest
requesttoken: 2n1bYMeQ6paa+cIQNGLMBqaXpGWv8JqILZsS2XLquBs=:ijoLBa/kouH0lYl6VVqcNtzUygedx/CndKtwnjSr/Eg=
Depth: 0
Content-Type: application/xml; charset=utf-8
If-Match: null
Content-Length: 247
Connection: keep-alive
Cookie: nc_sameSiteCookielax=true; nc_sameSiteCookiestrict=true; oc_sessionPassphrase=YHp76hadQQ5iXHPhtambAoGiWC67H8FH66wxYV0jxWKmWrMzp919ysVBWTZaIPOJ2c3QuGkKLyN6eEEGSn5J%2FWNeyJCKwhSUG1udvbXMm2GuSASPbp%2FKpYPPIM95lik4; ocbrb85g3rfg=vbttf5o4bn06e66ptbf2vq6tn5; nc_username=admin; nc_token=QH3MO9yKhF9jYmxcaKzX9HSwrFoq0UVJ; nc_session_id=vbttf5o4bn06e66ptbf2vq6tn5Antwortkopfzeilen:HTTP/1.1 412 Precondition failed
Date: Sat, 26 Jan 2019 08:12:42 GMT
Server: Apache/2.4.25 (Debian)
Expires: Thu, 19 Nov 1981 08:52:00 GMT
Cache-Control: no-store, no-cache, must-revalidate
Pragma: no-cache
Content-Security-Policy: default-src 'none';
X-Frame-Options: SAMEORIGIN
X-XSS-Protection: 1; mode=block
X-Content-Type-Options: nosniff
X-Robots-Tag: none
X-Download-Options: noopen
X-Permitted-Cross-Domain-Policies: none
Referrer-Policy: no-referrer
ETag: "36a3535aacc2e79aa358ae67875c438a"
Content-Length: 312
Keep-Alive: timeout=5, max=99
Connection: Keep-Alive
Content-Type: application/xml; charset=utf-8Antwortkopfzeilen (639 B)Cache-Controlno-store, no-cache, must-revalidateConnectionKeep-AliveContent-Length312Content-Security-Policydefault-src 'none';Content-Typeapplication/xml; charset=utf-8DateSat, 26 Jan 2019 08:12:42 GMTETag"36a3535aacc2e79aa358ae67875c438a"ExpiresThu, 19 Nov 1981 08:52:00 GMTKeep-Alivetimeout=5, max=99Pragmano-cacheReferrer-Policyno-referrerServerApache/2.4.25 (Debian)X-Content-Type-OptionsnosniffX-Download-OptionsnoopenX-Frame-OptionsSAMEORIGINX-Permitted-Cross-Domain-PoliciesnoneX-Robots-TagnoneX-XSS-Protection1; mode=blockAnfragekopfzeilen (929 B)Accept*/*Accept-Encodinggzip, deflateAccept-Languagede,en-US;q=0.7,en;q=0.3Connectionkeep-aliveContent-Length247Content-Typeapplication/xml; charset=utf-8Cookienc_sameSiteCookielax=true; nc_…id=vbttf5o4bn06e66ptbf2vq6tn5Depth0Host192.168.56.2If-Matchnullrequesttoken2n1bYMeQ6paa+cIQNGLMBqaXpGWv8J…6VVqcNtzUygedx/CndKtwnjSr/Eg=User-AgentMozilla/5.0 (Windows NT 10.0; …) Gecko/20100101 Firefox/64.0X-Requested-WithXMLHttpRequest

Second editing request (response header)

XHRPUThttp://192.168.56.2/nextcloud/remote.php/dav/calendars/admin/tasksonly/28D35DC6-8A8A-4947-8981-88666A21C67A.ics[HTTP/1.1 412 Precondition failed 131ms] 
KopfzeilenCookiesParameterAntwortZeitAufruflisteAngefragte Adresse:Anfragemethode:Externe Adresse:Status-Code:412Bearbeiten und erneut sendenKopfzeilen (unformatiert)Version:Anfragekopfzeilen:Host: 192.168.56.2
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0
Accept: */*
Accept-Language: de,en-US;q=0.7,en;q=0.3
Accept-Encoding: gzip, deflate
X-Requested-With: XMLHttpRequest
requesttoken: 2n1bYMeQ6paa+cIQNGLMBqaXpGWv8JqILZsS2XLquBs=:ijoLBa/kouH0lYl6VVqcNtzUygedx/CndKtwnjSr/Eg=
Depth: 0
Content-Type: application/xml; charset=utf-8
If-Match: null
Content-Length: 247
Connection: keep-alive
Cookie: nc_sameSiteCookielax=true; nc_sameSiteCookiestrict=true; oc_sessionPassphrase=YHp76hadQQ5iXHPhtambAoGiWC67H8FH66wxYV0jxWKmWrMzp919ysVBWTZaIPOJ2c3QuGkKLyN6eEEGSn5J%2FWNeyJCKwhSUG1udvbXMm2GuSASPbp%2FKpYPPIM95lik4; ocbrb85g3rfg=vbttf5o4bn06e66ptbf2vq6tn5; nc_username=admin; nc_token=QH3MO9yKhF9jYmxcaKzX9HSwrFoq0UVJ; nc_session_id=vbttf5o4bn06e66ptbf2vq6tn5Antwortkopfzeilen:HTTP/1.1 412 Precondition failed
Date: Sat, 26 Jan 2019 08:12:42 GMT
Server: Apache/2.4.25 (Debian)
Expires: Thu, 19 Nov 1981 08:52:00 GMT
Cache-Control: no-store, no-cache, must-revalidate
Pragma: no-cache
Content-Security-Policy: default-src 'none';
X-Frame-Options: SAMEORIGIN
X-XSS-Protection: 1; mode=block
X-Content-Type-Options: nosniff
X-Robots-Tag: none
X-Download-Options: noopen
X-Permitted-Cross-Domain-Policies: none
Referrer-Policy: no-referrer
ETag: "36a3535aacc2e79aa358ae67875c438a"
Content-Length: 312
Keep-Alive: timeout=5, max=99
Connection: Keep-Alive
Content-Type: application/xml; charset=utf-8Antwortkopfzeilen (639 B)Cache-Controlno-store, no-cache, must-revalidateConnectionKeep-AliveContent-Length312Content-Security-Policydefault-src 'none';Content-Typeapplication/xml; charset=utf-8DateSat, 26 Jan 2019 08:12:42 GMTETag"36a3535aacc2e79aa358ae67875c438a"ExpiresThu, 19 Nov 1981 08:52:00 GMTKeep-Alivetimeout=5, max=99Pragmano-cacheReferrer-Policyno-referrerServerApache/2.4.25 (Debian)X-Content-Type-OptionsnosniffX-Download-OptionsnoopenX-Frame-OptionsSAMEORIGINX-Permitted-Cross-Domain-PoliciesnoneX-Robots-TagnoneX-XSS-Protection1; mode=blockAnfragekopfzeilen (929 B)Accept*/*Accept-Encodinggzip, deflateAccept-Languagede,en-US;q=0.7,en;q=0.3Connectionkeep-aliveContent-Length247Content-Typeapplication/xml; charset=utf-8Cookienc_sameSiteCookielax=true; nc_…id=vbttf5o4bn06e66ptbf2vq6tn5Depth0Host192.168.56.2If-Matchnullrequesttoken2n1bYMeQ6paa+cIQNGLMBqaXpGWv8J…6VVqcNtzUygedx/CndKtwnjSr/Eg=User-AgentMozilla/5.0 (Windows NT 10.0; …) Gecko/20100101 Firefox/64.0X-Requested-WithXMLHttpRequest
@skjnldsv
Copy link
Member

@raimund-schluessler you're using the cdav-library?
We fixed the request queue here: nextcloud/contacts#879

@raimund-schluessler
Copy link
Member Author

@skjnldsv The Problem is I didn’t send the PRODID on creation, so that SabreDAV does not return an Etag.

Do you know how I get the app version in JavaScript?

@skjnldsv
Copy link
Member

@raimund-schluessler if you use the cdav library, the PUT is automatically followed by a PROPFIND :)

@georgehrke
Copy link
Member

@skjnldsv
Copy link
Member

Stupid question, but why do you need that? :)

@georgehrke
Copy link
Member

Stupid question, but why do you need that? :)

To put it into in the prodid of ics created by the calendar app 😉

@skjnldsv
Copy link
Member

skjnldsv commented Jan 26, 2019

@georgehrke Hum, we don't do that on contacts 🙈
I guess we should ? 😁

@raimund-schluessler
Copy link
Member Author

Thanks a lot for the hints. Fix is in #234

@skjnldsv
Copy link
Member

Question, do we have a standard to name our PRODID ? :)

@raimund-schluessler
Copy link
Member Author

Question, do we have a standard to name our PRODID ? :)

I am not aware of any. But might make sense to follow the same one. 🙂

@skjnldsv
Copy link
Member

skjnldsv commented Feb 1, 2019

Calendar is using 'PRODID:-//Nextcloud calendar v' + constants.version
Tasks: 'PRODID:-//Nextcloud Tasks v' + getAppVersion()

Let me use the same

@skjnldsv
Copy link
Member

skjnldsv commented Mar 22, 2019

Just so you know, we cannot do that for every browser.
For browsers that supports cspV3, we add all the js variables inline, in the document head. But for others (opera, safari, ie, edge...) we generate a script (/core/js/oc.js) that contains everything.
nextcloud/server@6dbe417#diff-7afe0377257ef7362517b1e27bda7ee6R146

the trick we mentioned above does not work anymore on 16.

I decided to use another way and implement it via webpack variables (taken from the package.json)
nextcloud/contacts#1010

@raimund-schluessler
Copy link
Member Author

Just so you know, we cannot do that for every browser.
For browsers that supports cspV3, we add all the js variables inline, in the document head. But for others (opera, safari, ie, edge...) we generate a script (/core/js/oc.js) that contains everything.
nextcloud/server@6dbe417#diff-7afe0377257ef7362517b1e27bda7ee6R146

the trick we mentioned above does not work anymore on 16.

I decided to use another way and implement it via webpack variables (taken from the package.json)
nextcloud/contacts#1010

Sounds like nextcloud/contacts#1010 is a good solution for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants