Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strike-through using Markdown does not work in task description #678

Closed
timholl opened this issue Oct 18, 2019 · 2 comments · Fixed by #682
Closed

Strike-through using Markdown does not work in task description #678

timholl opened this issue Oct 18, 2019 · 2 comments · Fixed by #682

Comments

@timholl
Copy link
Contributor

timholl commented Oct 18, 2019

Steps to reproduce

  1. Write a task description containing Markdown ~~Foo~~ .
  2. Click somewhere outside of the textarea, so it gets rendered by markdown-it.

Expected behaviour

The description should be displayed as "Foo".

Actual behaviour

The description is displayed as "Foo".

Server configuration

Operating system: Ubuntu Server

Web server: Apache

Database: Sqlite

PHP version: 7.2

Nextcloud version: 17.0.0

Tasks version: 0.11.3

Updated from an older Nextcloud or fresh install: Fresh install

@timholl
Copy link
Contributor Author

timholl commented Oct 18, 2019

Turns out that the global text-decoration:none CSS rule prevents the default style of <s> (as correctly created by markdown-it) inside the #markdown-container.

So a simple additional rule like

23a24,27
> 	s {
> 		text-decoration: line-through;
> 	}
>

in css/src/markdown.scssshould do the trick.

@raimund-schluessler
Copy link
Member

Fine with me, fix is in #682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants